unable to configure goodness_function

[Rodrigo Barbieri]

Manila allows configuring the backend option goodness_function per backend stanza for optimizing backend balance. This option is not available in the charm.

In case of NetApp, this is needed due to a problem in the driver when using SVM scoped accounts. It does not have enough permissions to obtain the total_capacity_gb information, so it cannot calculate utilization, and therefore the goodness_function always returns 50 and end up scheduling shares always to the same pool.

The goodness_function is necessary to overcome bug [1] where the driver is not reporting the utilization correctly due to the usage of SVM-scoped account, and therefore scheduling of shares is inefficient, requiring the use of a goodness_function to create a rule such as below based on free_capacity_gb to restore good enough scheduling while [1] is not fixed.

goodness_function = "(capabilities.free_capacity_gb / 1000)"

[1] https://bugs.launchpad.net/manila/+bug/2073599

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-manila-netapp/+/924438

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-manila-netapp/+/924438
Committed: https://opendev.org/openstack/charm-manila-netapp/commit/94a4d30901bf9edac08cdcb7363dcb42680e8c80
Submitter: "Zuul (22348)"
Branch: master

commit 94a4d30901bf9edac08cdcb7363dcb42680e8c80
Author: Rodrigo Barbieri <email address hidden>
Date: Thu Jul 18 17:09:24 2024 -0300

    Add goodness-function config

    This allows specifying functions that further optimize the scheduling
    of shares across backend stanzas.

    This is needed due to a netapp-driver specific problem when using
    SVM scoped accounts. It does not have enough permissions to obtain
    the total_capacity_gb information, so it cannot calculate utilization,
    and therefore the goodness_function always returns 50 and end up
    scheduling shares always to the same pool.

    Closes-bug: #2073537
    Change-Id: Ia151c50421e75282f633e0b004c2e6c1bda638f3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/charm-manila-netapp/+/925797

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-manila-netapp/+/925797
Committed: https://opendev.org/openstack/charm-manila-netapp/commit/5b8c04db1da67cdb22f137968d617bc29b9b9f53
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit 5b8c04db1da67cdb22f137968d617bc29b9b9f53
Author: Rodrigo Barbieri <email address hidden>
Date: Thu Jul 18 17:09:24 2024 -0300

    Add goodness-function config

    This allows specifying functions that further optimize the scheduling
    of shares across backend stanzas.

    This is needed due to a netapp-driver specific problem when using
    SVM scoped accounts. It does not have enough permissions to obtain
    the total_capacity_gb information, so it cannot calculate utilization,
    and therefore the goodness_function always returns 50 and end up
    scheduling shares always to the same pool.

    Closes-bug: #2073537
    Change-Id: Ia151c50421e75282f633e0b004c2e6c1bda638f3
    (cherry picked from commit 94a4d30901bf9edac08cdcb7363dcb42680e8c80)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/charm-manila-netapp/+/925978

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-manila-netapp/+/925978
Committed: https://opendev.org/openstack/charm-manila-netapp/commit/b550021fe2372bcbb6482d9851e7d8aa9e6017d8
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit b550021fe2372bcbb6482d9851e7d8aa9e6017d8
Author: Rodrigo Barbieri <email address hidden>
Date: Thu Jul 18 17:09:24 2024 -0300

    Add goodness-function config

    This allows specifying functions that further optimize the scheduling
    of shares across backend stanzas.

    This is needed due to a netapp-driver specific problem when using
    SVM scoped accounts. It does not have enough permissions to obtain
    the total_capacity_gb information, so it cannot calculate utilization,
    and therefore the goodness_function always returns 50 and end up
    scheduling shares always to the same pool.

    Closes-bug: #2073537
    Change-Id: Ia151c50421e75282f633e0b004c2e6c1bda638f3
    (cherry picked from commit 94a4d30901bf9edac08cdcb7363dcb42680e8c80)
    (cherry picked from commit 5b8c04db1da67cdb22f137968d617bc29b9b9f53)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/charm-manila-netapp/+/925995

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-manila-netapp/+/925995
Committed: https://opendev.org/openstack/charm-manila-netapp/commit/f500f4e03b189df42974f115018a7701d136d3e1
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit f500f4e03b189df42974f115018a7701d136d3e1
Author: Rodrigo Barbieri <email address hidden>
Date: Thu Jul 18 17:09:24 2024 -0300

    Add goodness-function config

    This allows specifying functions that further optimize the scheduling
    of shares across backend stanzas.

    This is needed due to a netapp-driver specific problem when using
    SVM scoped accounts. It does not have enough permissions to obtain
    the total_capacity_gb information, so it cannot calculate utilization,
    and therefore the goodness_function always returns 50 and end up
    scheduling shares always to the same pool.

    Closes-bug: #2073537
    Change-Id: Ia151c50421e75282f633e0b004c2e6c1bda638f3
    (cherry picked from commit 94a4d30901bf9edac08cdcb7363dcb42680e8c80)
    (cherry picked from commit 5b8c04db1da67cdb22f137968d617bc29b9b9f53)
    (cherry picked from commit b550021fe2372bcbb6482d9851e7d8aa9e6017d8)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/charm-manila-netapp/+/926125

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-manila-netapp/+/926125
Committed: https://opendev.org/openstack/charm-manila-netapp/commit/9e0ffda8820e97d55710dd6cfe823f8e5986bf3f
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 9e0ffda8820e97d55710dd6cfe823f8e5986bf3f
Author: Rodrigo Barbieri <email address hidden>
Date: Thu Jul 18 17:09:24 2024 -0300

    Add goodness-function config

    This allows specifying functions that further optimize the scheduling
    of shares across backend stanzas.

    This is needed due to a netapp-driver specific problem when using
    SVM scoped accounts. It does not have enough permissions to obtain
    the total_capacity_gb information, so it cannot calculate utilization,
    and therefore the goodness_function always returns 50 and end up
    scheduling shares always to the same pool.

    Closes-bug: #2073537
    Change-Id: Ia151c50421e75282f633e0b004c2e6c1bda638f3
    (cherry picked from commit 94a4d30901bf9edac08cdcb7363dcb42680e8c80)
    (cherry picked from commit 5b8c04db1da67cdb22f137968d617bc29b9b9f53)
    (cherry picked from commit b550021fe2372bcbb6482d9851e7d8aa9e6017d8)
    (cherry picked from commit f500f4e03b189df42974f115018a7701d136d3e1)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-manila-netapp/+/926289

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-manila-netapp/+/926289
Committed: https://opendev.org/openstack/charm-manila-netapp/commit/7d804c4550cd6ea461483138a18450383900510f
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 7d804c4550cd6ea461483138a18450383900510f
Author: Rodrigo Barbieri <email address hidden>
Date: Thu Jul 18 17:09:24 2024 -0300

    Add goodness-function config

    This allows specifying functions that further optimize the scheduling
    of shares across backend stanzas.

    This is needed due to a netapp-driver specific problem when using
    SVM scoped accounts. It does not have enough permissions to obtain
    the total_capacity_gb information, so it cannot calculate utilization,
    and therefore the goodness_function always returns 50 and end up
    scheduling shares always to the same pool.

    Closes-bug: #2073537
    Change-Id: Ia151c50421e75282f633e0b004c2e6c1bda638f3
    (cherry picked from commit 94a4d30901bf9edac08cdcb7363dcb42680e8c80)
    (cherry picked from commit 5b8c04db1da67cdb22f137968d617bc29b9b9f53)
    (cherry picked from commit b550021fe2372bcbb6482d9851e7d8aa9e6017d8)
    (cherry picked from commit f500f4e03b189df42974f115018a7701d136d3e1)
    (cherry picked from commit 9e0ffda8820e97d55710dd6cfe823f8e5986bf3f)