Manila-Ganesha is tracking ceph packages on workload version

Bug #2060751 reported by Gabriel Cocenza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Manila-Ganesha Charm
Fix Committed
Undecided
Gabriel Cocenza
2023.1
Fix Released
Undecided
Unassigned
2023.2
Fix Released
Undecided
Unassigned
Ussuri
Fix Released
Undecided
Unassigned
Victoria
Fix Released
Undecided
Unassigned
Wallaby
Fix Released
Undecided
Unassigned
Xena
Fix Released
Undecided
Unassigned
Yoga
Fix Released
Undecided
Unassigned
Zed
Fix Released
Undecided
Unassigned

Bug Description

The charm is not using `version_package` in the class and the first package in the packages list is ceph which makes this wrong traccking.

Revision history for this message
Andrea Ieri (aieri) wrote :

```
class ManilaGaneshaCharm(charms_openstack.charm.HAOpenStackCharm,
                         charms_openstack.plugins.BaseOpenStackCephCharm,
                         ):
    release = 'rocky'
    name = 'ganesha'
    python_version = 3
    source_config_key = 'openstack-origin'
    packages = [
        'ceph-common',
        'python3-cephfs',
        'python3-rados',
        'nfs-ganesha-ceph',
        'manila-share',
        'python3-manila',
    ]
```

basically the above makes charmhelpers (https://github.com/openstack/charms.openstack/blob/018b72d734223db274b59f524b7887d8153cdb6d/charms_openstack/charm/classes.py#L215) populate workload_version in the juju status with the ceph-common version instead of one of the manila-specific packages version

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (master)
Changed in charm-manila-ganesha:
status: New → In Progress
Changed in charm-manila-ganesha:
assignee: nobody → Gabriel Cocenza (gabrielcocenza)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (master)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915426
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/66f641392c69516553db2ec78e95de47a0cb10db
Submitter: "Zuul (22348)"
Branch: master

commit 66f641392c69516553db2ec78e95de47a0cb10db
Author: Gabriel Cocenza <email address hidden>
Date: Wed Apr 10 10:38:08 2024 -0300

    Fix application version on manila-ganesha charm

    The charm is not using `version_package` in the class and it's
    using the default to the first in packages which is Ceph.

    Closes-bug: #2060751
    Change-Id: Id745140a316120e56948f3770f2b2473d1134255

Changed in charm-manila-ganesha:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915450

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915451

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915452

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (stable/xena)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (stable/yoga)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (stable/zed)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915456

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915458

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915458
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/e8e88057fa85818105819cc3156fbc8b7fd750d8
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit e8e88057fa85818105819cc3156fbc8b7fd750d8
Author: Gabriel Cocenza <email address hidden>
Date: Wed Apr 10 10:38:08 2024 -0300

    Fix application version on manila-ganesha charm

    The charm is not using `version_package` in the class and it's
    using the default to the first in packages which is Ceph.

    Closes-bug: #2060751
    Change-Id: Id745140a316120e56948f3770f2b2473d1134255
    (cherry picked from commit 66f641392c69516553db2ec78e95de47a0cb10db)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915456
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/790dcb2be7a52a0ecd016c671792ef409347b4e8
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 790dcb2be7a52a0ecd016c671792ef409347b4e8
Author: Gabriel Cocenza <email address hidden>
Date: Wed Apr 10 10:38:08 2024 -0300

    Fix application version on manila-ganesha charm

    The charm is not using `version_package` in the class and it's
    using the default to the first in packages which is Ceph.

    Closes-bug: #2060751
    Change-Id: Id745140a316120e56948f3770f2b2473d1134255
    (cherry picked from commit 66f641392c69516553db2ec78e95de47a0cb10db)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915455
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/f8189bf6a8321d6acd99edbbc012bb98656360d7
Submitter: "Zuul (22348)"
Branch: stable/zed

commit f8189bf6a8321d6acd99edbbc012bb98656360d7
Author: Gabriel Cocenza <email address hidden>
Date: Wed Apr 10 10:38:08 2024 -0300

    Fix application version on manila-ganesha charm

    The charm is not using `version_package` in the class and it's
    using the default to the first in packages which is Ceph.

    Closes-bug: #2060751
    Change-Id: Id745140a316120e56948f3770f2b2473d1134255
    (cherry picked from commit 66f641392c69516553db2ec78e95de47a0cb10db)

tags: added: in-stable-zed
tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915454
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/2bac479d5ef1e47d7687660fd1d4f4c4dfa01378
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 2bac479d5ef1e47d7687660fd1d4f4c4dfa01378
Author: Gabriel Cocenza <email address hidden>
Date: Wed Apr 10 10:38:08 2024 -0300

    Fix application version on manila-ganesha charm

    The charm is not using `version_package` in the class and it's
    using the default to the first in packages which is Ceph.

    Closes-bug: #2060751
    Change-Id: Id745140a316120e56948f3770f2b2473d1134255
    (cherry picked from commit 66f641392c69516553db2ec78e95de47a0cb10db)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915453
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/3989ef3811b13690b7ee7cdbf0a61767338ad315
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 3989ef3811b13690b7ee7cdbf0a61767338ad315
Author: Gabriel Cocenza <email address hidden>
Date: Wed Apr 10 10:38:08 2024 -0300

    Fix application version on manila-ganesha charm

    The charm is not using `version_package` in the class and it's
    using the default to the first in packages which is Ceph.

    Closes-bug: #2060751
    Change-Id: Id745140a316120e56948f3770f2b2473d1134255
    (cherry picked from commit 66f641392c69516553db2ec78e95de47a0cb10db)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915452
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/c8876bae7992a0ed423a9bc372385ff6668c6fbf
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c8876bae7992a0ed423a9bc372385ff6668c6fbf
Author: Gabriel Cocenza <email address hidden>
Date: Wed Apr 10 10:38:08 2024 -0300

    Fix application version on manila-ganesha charm

    The charm is not using `version_package` in the class and it's
    using the default to the first in packages which is Ceph.

    Closes-bug: #2060751
    Change-Id: Id745140a316120e56948f3770f2b2473d1134255
    (cherry picked from commit 66f641392c69516553db2ec78e95de47a0cb10db)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915451
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/cf45f89950791633c34928cfb5e8f0fc1bd4308a
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit cf45f89950791633c34928cfb5e8f0fc1bd4308a
Author: Gabriel Cocenza <email address hidden>
Date: Wed Apr 10 10:38:08 2024 -0300

    Fix application version on manila-ganesha charm

    The charm is not using `version_package` in the class and it's
    using the default to the first in packages which is Ceph.

    Closes-bug: #2060751
    Change-Id: Id745140a316120e56948f3770f2b2473d1134255
    (cherry picked from commit 66f641392c69516553db2ec78e95de47a0cb10db)

tags: added: in-stable-victoria
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/915450
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/492185164bd82d335f83b26eb1a333ed23bdf613
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 492185164bd82d335f83b26eb1a333ed23bdf613
Author: Gabriel Cocenza <email address hidden>
Date: Wed Apr 10 10:38:08 2024 -0300

    Fix application version on manila-ganesha charm

    The charm is not using `version_package` in the class and it's
    using the default to the first in packages which is Ceph.

    - also include fix for the CI

    Closes-bug: #2060751
    Change-Id: Id745140a316120e56948f3770f2b2473d1134255
    (cherry picked from commit 66f641392c69516553db2ec78e95de47a0cb10db)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.