Accepting a percentage for min_speed

Bug #1977784 reported by Nobuto Murata
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
charm-magpie
Fix Committed
Undecided
Samuel Allan

Bug Description

Currently "min_speed" config option only accepts an absolute value of bandwidth.
https://charmhub.io/magpie/configure#min_speed
> min_speed | int
>
> Minimum transfer speed in mbit/s required to pass the test. 0 disables.

It would be nice if it can accept a percentage like 80% or 90% of the link speed so it would be easier to use the option in a mixed link speed environment (1Gbps + 10Gbps or 10Gbps + 40Gbps).

Changed in charm-magpie:
assignee: nobody → Samuel Walladge (swalladge)
Changed in charm-magpie:
status: New → In Progress
Revision history for this message
Samuel Allan (samuelallan) wrote :
Revision history for this message
Nobuto Murata (nobuto) wrote :

Subscribing ~field-medium.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-magpie (master)

Reviewed: https://review.opendev.org/c/openstack/charm-magpie/+/845084
Committed: https://opendev.org/openstack/charm-magpie/commit/720b6357264ae1fe493456304fe986e95b9ca131
Submitter: "Zuul (22348)"
Branch: master

commit 720b6357264ae1fe493456304fe986e95b9ca131
Author: Samuel Walladge <email address hidden>
Date: Wed Jun 8 15:36:49 2022 +0930

    Add support for min_speed percentage of link speed

    This can be useful for environments with mixed link speeds.

    Example:

    ```
    juju config magpie min_speed=80%
    ```

    Further note on behaviour: if a percentage min_speed is set,
    and the link is virtual or otherwise returns a negative speed,
    magpie will fail the speed check.
    (percentage of an undefined value is still undefined)

    Closes-Bug: #1977784

    Change-Id: I1fa5d38a4da26ca38e98350d1a1625184dff2363

Changed in charm-magpie:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.