minor packet loss not detected

[Samuel Allan]

Currently, if a network connection is flaky, magpie will not necessarily detect it. Iperf will succeed, and with the current configuration and defaults, ping tests will usually succeed.

We need to add more pings by default, and fail the ping test if enough packet loss is detected (ie. over some threshold).

[Samuel Allan (samuelallan)]

https://review.opendev.org/c/openstack/charm-magpie/+/841826

[Nobuto Murata (nobuto)]

Subscribing ~field-medium to get reviews to the proposed patch and merged when appropriate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-magpie/+/841826
Committed: https://opendev.org/openstack/charm-magpie/commit/ca6b68cf4198ed9656c86b4c124785f97f098f24
Submitter: "Zuul (22348)"
Branch: master

commit ca6b68cf4198ed9656c86b4c124785f97f098f24
Author: Samuel Walladge <email address hidden>
Date: Mon May 16 11:32:00 2022 +0930

    Detect minor packet loss in ping step

    Improve how the ping check works to detect packet loss.
    Previously, the ping check would only fail
    with high packet loss situations.

    Add charm config for interval between sending ping packets,
    so we have more control for tuning if required.

    In the juju status output message,
    the percentage of packet loss will now be shown for each host
    if there was packet loss.
    Examples:

    - 100% loss (total failure): icmp failed: ['1: 100% packet loss']
    - some loss, but not total: icmp failed: ['1: 25% packet loss']
    - host 1 total failure, host 2 with some packet loss:
        icmp failed: ['1: 100% packet loss', '2: 25% packet loss']
    - all good: icmp ok

    Finally, drop the py35 tox test env,
    because python 3.5 is no longer supported.

    Closes-Bug: #1973606
    Closes-Bug: #1973659

    Change-Id: I50dbbf4d0e0df8f36b9eb63aedd69ddc845f167d