Address code review #378334

Bug #1864575 reported by Paul Goins
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
logrotate-charm
Invalid
Medium
Unassigned

Bug Description

Several improvements were suggested in a previous code review: https://code.launchpad.net/~logrotate-charmers/charm-logrotated/+git/logrotate-charm/+merge/378334

However, as the charm in the charm store was updated with this code before the MR was approved, the decision was made to merge the above MR as-is so as not to revert added functionality.

The intent is for the issues raised in the above MR to be reviewed and, as appropriate, addressed.

Edin S (exsdev)
Changed in charm-logrotated:
importance: Undecided → Medium
Eric Chen (eric-chen)
Changed in charm-logrotated:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.