config docker-opts in kubernetes-worker is ineffective

[E. MAS]

I deployed a few days ago , a new version of my kubernetes cluster .

Because i use a private / insecure registry , i set in my overlay yaml a value for docker-opts .

extract of my overlay

  kubernetes-worker:
    options:
      docker-opts: --insecure-registry=dockreg.dev.prv:5000
      http_proxy: http://proxy.prv:3128
      https_proxy: http://proxy.prv:3128
      allow-privileged: "true"

This was working before

i dont see my option in
/etc/default/docker

but the proxy option are correct in
/lib/systemd/system/docker.service

Model Controller Cloud/Region Version SLA Timestamp
k8-42 juju-dev maas-prv 2.4.7 unsupported 17:22:16-04:00

App Version Status Scale Charm Store Rev OS Notes
easyrsa 3.0.1 active 1 easyrsa jujucharms 231 ubuntu
etcd 3.2.10 waiting 3 etcd jujucharms 411 ubuntu
flannel 0.10.0 active 5 flannel jujucharms 398 ubuntu
kubeapi-load-balancer 1.14.0 active 1 kubeapi-load-balancer jujucharms 617 ubuntu exposed
kubernetes-master 1.14.1 active 2 kubernetes-master jujucharms 642 ubuntu
kubernetes-worker 1.14.1 active 3 kubernetes-worker jujucharms 508 ubuntu exposed

[E. MAS (erwan-mas)]

When you rollback this file
https://github.com/charmed-kubernetes/layer-docker/blob/master/reactive/docker.py
 to commit 907b7cbfe9ff50676d8143fec6c7434a6f749efb

this is working

[E. MAS (erwan-mas)]

Joseph Borg , your commit 0a6b0f97fa9446d0ae21dc872c2fe3d1a783fd29 generate a regression

https://github.com/charmed-kubernetes/layer-docker/commit/0a6b0f97fa9446d0ae21dc872c2fe3d1a783fd29

[George Kraft (cynerva)]

Looks like we accidentally removed the code that handles docker-opts in this PR: https://github.com/juju-solutions/layer-docker/pull/135

[E. MAS (erwan-mas)]

A simple patch that fix the regression

[E. MAS (erwan-mas)]

i created a pull request https://github.com/juju-solutions/layer-docker/pull/136

[George Kraft (cynerva)]

Thanks for the fix. It will be in kubernetes-worker revision 522+.

[Rodrigo Barbieri (rodrigo-barbieri2010)]

Thanks for this fix! =)

Is it possible to include it in the next stable hotfix release?

[Mike Wilson (knobby)]

Added a test to prevent regression:

https://github.com/charmed-kubernetes/jenkins/pull/399

[George Kraft (cynerva)]

> Is it possible to include it in the next stable hotfix release?

We do intend to put this out with a stable hotfix release, but I don't think we have a concrete timeline for that yet.

[George Kraft (cynerva)]

PR to stable branch: https://github.com/charmed-kubernetes/layer-docker/pull/1