missing StorageClass with juju.io/workload-storage annotation when using AWS integrator

[Ian Booth]

Each node provisioned by a CDK deployment (master or worker) should set a node label:

juju.io/cloud=<cloud>

where cloud is one of "gce", "ec2", "azure", "openstack"

I think this was meant to be done when the integrator charm was related to the master/worker charms.

Juju needs this information to detect the underlying cloud. I am sure this was working since Juju used to not need the --cloud option when using add-k8s.

I also thought CDK would create a storage class with the juju.io/workload-storage annotation. The add-on templates seem to be there https://github.com/charmed-kubernetes/cdk-addons
so maybe there's an issue elsewhere?

I deployed CDK like so:

$ juju deploy charmed-kubernetes --overlay aws-overlay.yaml --trust

Is this a regression or I am doing something wrong? The expectation is that after deploying CDK and relating to the relevant integrator charm, juju add-k8s should Just Work. Node labels and a suitable storage class are needed for this to happen.

[George Kraft (cynerva)]

We already have an open issue regarding the juju.io/cloud node label. Please direct all further discussion of that here: https://bugs.launchpad.net/charm-kubernetes-worker/+bug/1830119

Let's focus this issue on the StorageClass and juju.io/workload-storage annotation side of things.

[George Kraft (cynerva)]

The StorageClasses exist in cdk-addons, but kubernetes-master only enables the one for OpenStack: https://github.com/charmed-kubernetes/charm-kubernetes-master/blob/7fba57c011641eb449c5ef7a2831f343493fba68/reactive/kubernetes_master.py#L1080-L1085

[Ian Booth (wallyworld)]

With the storage class addon templates for Juju, it's important that WaitForFirstConsumer option is set when creating the storage classes. Could we please ensure the yaml templates are updated to have that.