[RFE] VIP address is not validated

Bug #1958178 reported by Peter Matulis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack HA Cluster Charm
Triaged
Wishlist
Sudeep Bhandari
OpenStack Keystone Charm
Fix Committed
Undecided
Sudeep Bhandari

Bug Description

It would be great if the hacluster charm could validate whether the configured VIP address resides on the subnet in use.

summary: - [RFE] VIP subnet is not validated
+ [RFE] VIP address is not validated
description: updated
Changed in charm-hacluster:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: good-first-bug
Revision history for this message
Felipe Reyes (freyes) wrote :

Hi Peter, what would be the behavior you expect?, because the principle charms own the 'vip' configuration, and IIRC a vip is discarded when no subnet is configured in the unit.

Revision history for this message
Peter Matulis (petermatulis) wrote :

Yeah I realise its a principal charm configuration but isn't that info transferred to the hacluster charm? Regardless, this is one of those things that can save users a lot of time when an invalid address is supplied by mistake. I would like to see messaging in `juju status` output, whether from the principal charm or the hacluster charm.

Changed in charm-hacluster:
assignee: nobody → Sudeep Bhandari (sudeephb)
Changed in charm-keystone:
assignee: nobody → Sudeep Bhandari (sudeephb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-keystone (master)
Changed in charm-keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-keystone (master)

Reviewed: https://review.opendev.org/c/openstack/charm-keystone/+/849497
Committed: https://opendev.org/openstack/charm-keystone/commit/965d292bd442a355403394d85dc4cd5a1839314d
Submitter: "Zuul (22348)"
Branch: master

commit 965d292bd442a355403394d85dc4cd5a1839314d
Author: sudeephb <email address hidden>
Date: Tue Jul 12 17:18:48 2022 +0545

    Validate vip address

    Validates if the provided vip address(es) are in the subnet that the unit is in. If not, shows the message with invalid vips along with 'blocked' status.

    Closes-Bug: #1958178
    Change-Id: I6bb3e21f3934d6d2483564fba9216504a62d15dc

Changed in charm-keystone:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.