manager.py crashed during upgrade-charm hook

[Chris MacNaughton]

This causes a keystone hook error, failing the charm upgrade

[Ryan Beisner (1chb1n)]

See related: https://bugs.launchpad.net/charm-keystone/+bug/1822063

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/650919
Committed: https://git.openstack.org/cgit/openstack/charm-keystone/commit/?id=78f0191aa8251f97f1c2bb66fe7c2a35b99f26f7
Submitter: Zuul
Branch: master

commit 78f0191aa8251f97f1c2bb66fe7c2a35b99f26f7
Author: Alex Kavanagh <email address hidden>
Date: Mon Apr 8 16:01:07 2019 +0100

    Ensure that manager.py is stopped when keystone restarted

    This patch ensures that any running manager.py script is stopped if the
    keystone service (either standalone, or run via apache2) is restarted.
    The ManagerServer will automatically (re)start the manager.py script
    when it is needed.

    Change-Id: I4e3dff340cce73b2de7d697f3685d602defb5179
    Related-Bug: #1823743

[Alex Kavanagh (ajkavanagh)]

There are still issues around manager.py; going to try to sort out a more permanent fix in the manager.py to reconnect if there is a 500 error (indicating, possibly, that the context between the python client and the server has changed due to the upgrade.)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/653019

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/653019
Committed: https://git.openstack.org/cgit/openstack/charm-keystone/commit/?id=023dd35a5ab3b0278b7c13cbc8b5ff427257fc83
Submitter: Zuul
Branch: master

commit 023dd35a5ab3b0278b7c13cbc8b5ff427257fc83
Author: Alex Kavanagh <email address hidden>
Date: Tue Apr 16 15:50:38 2019 +0100

    Ensure that the manager.py re-connects if it gets a 500 error

    This patch works around a bug during upgrades where (it is believed)
    that the manager.py script can hold a 'stale' connection to the apache2
    hosted keystone, which then returns a 500 HTTP error when next used.

    Change-Id: Id9c9b967742467f30270f52c2a8b6634f6480324
    Related-Bug: #1823743