limited coverage of generate_pod_config

Bug #1888640 reported by John A Meinel
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

There is only a single test in:

which only tests the 'generate_pod_config' code, and doesn't even cover the 'secure' case. (jenkins_api_token is a mandatory config item that will raise KeyError if you actually tried to set a pod spec without it)

It also doesn't test what would happen if you *did* set any of the other items (like jenkins_master_url).

John A Meinel (jameinel)
summary: - missing coverage of is_valid_config
+ limited coverage of generate_pod_config
Tom Haddon (mthaddon)
Changed in charm-k8s-jenkins-agent:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Tom Haddon (mthaddon) wrote :

We've since updated tests for this charm, and currently have 100% unit test coverage.

Changed in charm-k8s-jenkins-agent:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers