enable specific hardware functionalities for deployment

[Narinder Gupta]

This request is to enable the individual hardware vendor specific feature like hardware raid, network bonding etc during deployment of Ironic nodes. Below parameters are required to configure to have it enabled. Currently tested with Dell and HPE hardware test in progress

enabled_hardware_types = intel-ipmi, ipmi, idrac
enabled_management_interfaces = intel-ipmitool, ipmitool, noop, idrac-wsman
enabled_inspect_interfaces = no-inspect, idrac-wsman
enabled_power_interfaces = ipmitool, idrac-wsman
enabled_console_interfaces = ipmitool-shellinabox, ipmitool-socat, no-console
enabled_vendor_interfaces = ipmitool, no-vendor, idrac-wsman
enabled_raid_interfaces = agent, no-raid, idrac-wsman

[Felipe Reyes (freyes)]

To implement this request we'll introduce a new config option (e.g. `hardware-enablement-options`) that will allow operators to inject any configuration key related to hardware enablement tasks, it will be non-opinionated in terms of what keys are allowed.

[Felipe Reyes (freyes)]

added bug task to the charm-guide to make sure this config option gets documented.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876437

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876437
Committed: https://opendev.org/openstack/charm-ironic-conductor/commit/41efb85ef64ed4e4f35754ba3509063029fbca35
Submitter: "Zuul (22348)"
Branch: master

commit 41efb85ef64ed4e4f35754ba3509063029fbca35
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 28 12:34:56 2023 -0300

    Add configuration option 'hardware-enablement-options'

    This new config option allows operators to pass custom configuration
    options to the ironic-conductor service.

    Usage example:

        cat << EOF > ./config.txt
        [DEFAULT]
        enabled_hardware_types = intel-ipmi, ipmi, idrac
        enabled_power_interfaces = ipmitool, idrac-wsman
        EOF
        juju config ironic-conductor \
            hardware-enablement-options=@./config.txt

    Closes-Bug: #2002151
    Change-Id: I3e2ca81b272e61e4069d80b52902b243a5f0ba19

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876677

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876861

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876862

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876863

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876864

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876865

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876677
Committed: https://opendev.org/openstack/charm-ironic-conductor/commit/0ec212e237da4600f24f2bb361ff5d536f82e995
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 0ec212e237da4600f24f2bb361ff5d536f82e995
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 28 12:34:56 2023 -0300

    Add configuration option 'hardware-enablement-options'

    This new config option allows operators to pass custom configuration
    options to the ironic-conductor service.

    Usage example:

        cat << EOF > ./config.txt
        [DEFAULT]
        enabled_hardware_types = intel-ipmi, ipmi, idrac
        enabled_power_interfaces = ipmitool, idrac-wsman
        EOF
        juju config ironic-conductor \
            hardware-enablement-options=@./config.txt

    Closes-Bug: #2002151
    Change-Id: I3e2ca81b272e61e4069d80b52902b243a5f0ba19
    (cherry picked from commit 41efb85ef64ed4e4f35754ba3509063029fbca35)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876861
Committed: https://opendev.org/openstack/charm-ironic-conductor/commit/e377181d422b1e50eb0f161702ea23bee311d9f9
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit e377181d422b1e50eb0f161702ea23bee311d9f9
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 28 12:34:56 2023 -0300

    Add configuration option 'hardware-enablement-options'

    This new config option allows operators to pass custom configuration
    options to the ironic-conductor service.

    Usage example:

        cat << EOF > ./config.txt
        [DEFAULT]
        enabled_hardware_types = intel-ipmi, ipmi, idrac
        enabled_power_interfaces = ipmitool, idrac-wsman
        EOF
        juju config ironic-conductor \
            hardware-enablement-options=@./config.txt

    Closes-Bug: #2002151
    Change-Id: I3e2ca81b272e61e4069d80b52902b243a5f0ba19
    (cherry picked from commit 41efb85ef64ed4e4f35754ba3509063029fbca35)
    (cherry picked from commit 0ec212e237da4600f24f2bb361ff5d536f82e995)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876862
Committed: https://opendev.org/openstack/charm-ironic-conductor/commit/166be64d1f7bfb9b6132b639be9812c1674023d4
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 166be64d1f7bfb9b6132b639be9812c1674023d4
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 28 12:34:56 2023 -0300

    Add configuration option 'hardware-enablement-options'

    This new config option allows operators to pass custom configuration
    options to the ironic-conductor service.

    Usage example:

        cat << EOF > ./config.txt
        [DEFAULT]
        enabled_hardware_types = intel-ipmi, ipmi, idrac
        enabled_power_interfaces = ipmitool, idrac-wsman
        EOF
        juju config ironic-conductor \
            hardware-enablement-options=@./config.txt

    Closes-Bug: #2002151
    Change-Id: I3e2ca81b272e61e4069d80b52902b243a5f0ba19
    (cherry picked from commit 41efb85ef64ed4e4f35754ba3509063029fbca35)
    (cherry picked from commit 0ec212e237da4600f24f2bb361ff5d536f82e995)
    (cherry picked from commit e377181d422b1e50eb0f161702ea23bee311d9f9)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876865
Committed: https://opendev.org/openstack/charm-ironic-conductor/commit/b61503d6d0c9d855ef65b63d6b353527b8deac31
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit b61503d6d0c9d855ef65b63d6b353527b8deac31
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 28 12:34:56 2023 -0300

    Add configuration option 'hardware-enablement-options'

    This new config option allows operators to pass custom configuration
    options to the ironic-conductor service.

    Usage example:

        cat << EOF > ./config.txt
        [DEFAULT]
        enabled_hardware_types = intel-ipmi, ipmi, idrac
        enabled_power_interfaces = ipmitool, idrac-wsman
        EOF
        juju config ironic-conductor \
            hardware-enablement-options=@./config.txt

    Closes-Bug: #2002151
    Change-Id: I3e2ca81b272e61e4069d80b52902b243a5f0ba19
    (cherry picked from commit 41efb85ef64ed4e4f35754ba3509063029fbca35)
    (cherry picked from commit 0ec212e237da4600f24f2bb361ff5d536f82e995)
    (cherry picked from commit e377181d422b1e50eb0f161702ea23bee311d9f9)
    (cherry picked from commit 166be64d1f7bfb9b6132b639be9812c1674023d4)
    (cherry picked from commit e495f42d6dca7527476983a6242fa986ccd5a35f)
    (cherry picked from commit 07fe82be4be65740070d12da0ff554b3ab4a576c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876863
Committed: https://opendev.org/openstack/charm-ironic-conductor/commit/e495f42d6dca7527476983a6242fa986ccd5a35f
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit e495f42d6dca7527476983a6242fa986ccd5a35f
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 28 12:34:56 2023 -0300

    Add configuration option 'hardware-enablement-options'

    This new config option allows operators to pass custom configuration
    options to the ironic-conductor service.

    Usage example:

        cat << EOF > ./config.txt
        [DEFAULT]
        enabled_hardware_types = intel-ipmi, ipmi, idrac
        enabled_power_interfaces = ipmitool, idrac-wsman
        EOF
        juju config ironic-conductor \
            hardware-enablement-options=@./config.txt

    Closes-Bug: #2002151
    Change-Id: I3e2ca81b272e61e4069d80b52902b243a5f0ba19
    (cherry picked from commit 41efb85ef64ed4e4f35754ba3509063029fbca35)
    (cherry picked from commit 0ec212e237da4600f24f2bb361ff5d536f82e995)
    (cherry picked from commit e377181d422b1e50eb0f161702ea23bee311d9f9)
    (cherry picked from commit 166be64d1f7bfb9b6132b639be9812c1674023d4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/876864
Committed: https://opendev.org/openstack/charm-ironic-conductor/commit/07fe82be4be65740070d12da0ff554b3ab4a576c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 07fe82be4be65740070d12da0ff554b3ab4a576c
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 28 12:34:56 2023 -0300

    Add configuration option 'hardware-enablement-options'

    This new config option allows operators to pass custom configuration
    options to the ironic-conductor service.

    Usage example:

        cat << EOF > ./config.txt
        [DEFAULT]
        enabled_hardware_types = intel-ipmi, ipmi, idrac
        enabled_power_interfaces = ipmitool, idrac-wsman
        EOF
        juju config ironic-conductor \
            hardware-enablement-options=@./config.txt

    Closes-Bug: #2002151
    Change-Id: I3e2ca81b272e61e4069d80b52902b243a5f0ba19
    (cherry picked from commit 41efb85ef64ed4e4f35754ba3509063029fbca35)
    (cherry picked from commit 0ec212e237da4600f24f2bb361ff5d536f82e995)
    (cherry picked from commit e377181d422b1e50eb0f161702ea23bee311d9f9)
    (cherry picked from commit 166be64d1f7bfb9b6132b639be9812c1674023d4)
    (cherry picked from commit e495f42d6dca7527476983a6242fa986ccd5a35f)

[Felipe Reyes (freyes)]

To enable an environment with the 'idrac' driver like in the original description, the operator can run the following commands:

cat << EOF > ./idrac.ini
[DEFAULT]
enabled_hardware_types = intel-ipmi, ipmi, idrac
enabled_management_interfaces = intel-ipmitool, ipmitool, noop, idrac-wsman
enabled_inspect_interfaces = no-inspect, idrac-wsman
enabled_power_interfaces = ipmitool, idrac-wsman
enabled_console_interfaces = ipmitool-shellinabox, ipmitool-socat, no-console
enabled_vendor_interfaces = ipmitool, no-vendor, idrac-wsman
enabled_raid_interfaces = agent, no-raid, idrac-wsman
EOF
juju config ironic-conductor hardware-enablement-options=@./idrac.ini

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-guide/+/877104

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-guide/+/877104
Committed: https://opendev.org/openstack/charm-guide/commit/3a37d0ad15d33b8f9cfd3b3c8fec5be50a0ed2ce
Submitter: "Zuul (22348)"
Branch: master

commit 3a37d0ad15d33b8f9cfd3b3c8fec5be50a0ed2ce
Author: Felipe Reyes <email address hidden>
Date: Fri Mar 10 12:10:55 2023 -0300

    ironic-conductor charm: hardware enablement configuration

    Closes-Bug: #2002151
    Change-Id: I90ff1720bac6a0b8a8255e16073c9e51bd025235

[Arunkumar (arunptra)]

With hardware-enablement-options, we tried to update HP ILO hardware type required parameters. In juju config command not getting error, but juju not updated the configuration file.

juju config ironic-conductor hardware-enablement-options=@./ilo.ini

ubuntu@prepodhost01:~$ cat ilo.ini
[DEFAULT]
enabled_hardware_types = intel-ipmi, ipmi, idrac, ilo5
enabled_boot_interfaces = pxe,ilo-pxe
enabled_management_interfaces = intel-ipmitool, ipmitool, noop, idrac-wsman, ilo5
enabled_inspect_interfaces = no-inspect, idrac-wsman
enabled_power_interfaces = ipmitool, idrac-wsman, ilo
enabled_storage_interfaces = cinder,noop
enabled_console_interfaces = ipmitool-shellinabox, ipmitool-socat, no-console
enabled_vendor_interfaces = ipmitool, no-vendor, idrac-wsman
enabled_raid_interfaces = agent, no-raid, idrac-wsman, ilo5
ubuntu@prepodhost01:~$

ubuntu@prepodhost01:~$ juju status ironic-conductor
Model Controller Cloud/Region Version SLA Timestamp
openstack foundations-maas maas_cloud 2.9.29 unsupported 14:20:25Z

SAAS Status Store URL
ceph-mon-az1-client active foundations-maas admin/ceph-prepod.ceph-mon-az1-client
ceph-mon-az1-radosgw active foundations-maas admin/ceph-prepod.ceph-mon-az1-radosgw
ceph-mon-az2-client error foundations-maas admin/ceph-prepod.ceph-mon-az2-client
ceph-mon-az2-radosgw error foundations-maas admin/ceph-prepod.ceph-mon-az2-radosgw
grafana active foundations-maas admin/lma.grafana-dashboards
graylog waiting foundations-maas admin/lma.graylog-beats
nagios active foundations-maas admin/lma.nagios-monitors
prometheus active foundations-maas admin/lma.prometheus-target
vault error foundations-maas admin/ceph-prepod.vault

App Version Status Scale Charm Channel Rev Exposed Message
filebeat 6.8.23 active 2 filebeat stable 24 no Filebeat ready.
ironic-conductor 4.2 active 2 ironic-conductor ussuri/stable 87 no Unit is ready
ironic-conductor-mysql-router 8.0.28 active 2 mysql-router 8.0/stable 35 no Unit is ready
landscape-client maintenance 2 landscape-client stable 35 no Need computer-title and juju-info to proceed
logrotate active 2 logrotated stable 3 no Unit is ready.
nrpe-container active 2 nrpe stable 75 no Ready (source version/commit cs-nrpe-...)
ntp 3.5 error 2 ntp stable 50 no hook failed: "update-status"
public-policy-routing active 2 advanced-routing stable 4 no Unit is ready
telegraf active 2 telegraf stable 44 no Monitoring contrail-haproxy/1 (source version/commit 26e531a)

Unit Work...

[Felipe Reyes (freyes)]

Hi Arunkumar, what's the error?, juju status is not showing any hook error for ironic-conductor:

 ironic-conductor 4.2 active 2 ironic-conductor ussuri/stable 87 no Unit is ready

[Arunkumar (arunptra)]

Hi Felipe,

There is no error while running juju config commands, but default section in ironic.conf file not getting updated.

Thanks,
Arunkumar Palanisamy

[Felipe Reyes (freyes)]

On Tue, 2023-04-18 at 14:26 +0000, Arunkumar wrote:
> Hi Felipe,
>
> There is no error while running juju config commands, but default
> section in ironic.conf file not getting updated.

The chunk of configuration passed via 'juju config' gets rendered under /etc/ironic/conf.d/90-
hardware-enablement.conf , can you check if that file exists and if the content is what you expect?