ironic-conductor fails to start on yoga

[Liam Young]

The ironic-conductor fails to start and /var/log/ironic/ironic-conductor.log
contains the error:

2022-04-13 09:13:07.467 76411 ERROR oslo_service.service ironic.common.exception.DriverLoadError: Driver, hardware type or interface pxe could not be loaded. Reason: [Errno 13] Permission denied: '/tftpboot/grub/'.

This appears to be caused by a change in ironic *1 which adds the grub.cfg as
file that is now managed by the conductor service. This clashes with the
charm which also manages the grub.cfg. The charm is the first to write the
file to disk and writes is and sets the permissions so that it is owner
by root and group ironic but with perms 640. This stops the ironic-conductor,
running as the ironic user, from updating the file.

*1 https://review.opendev.org/c/openstack/ironic/+/815580

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/837934

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/837934
Committed: https://opendev.org/openstack/charm-ironic-conductor/commit/a3b68bd8df73d37005bebc230e3c2f3343e39034
Submitter: "Zuul (22348)"
Branch: master

commit a3b68bd8df73d37005bebc230e3c2f3343e39034
Author: Liam Young <email address hidden>
Date: Thu Apr 14 16:47:26 2022 +0000

    Stop managing grub.cfg in Yoga

    From yoga onwards the ironic-conductor manges the grub.conf. This
    change ensure that the charm stops managing it. This change also
    ensures that the file permissions are set correctly prior to
    the upgrade to Yoga.

    While developing this change it became apparent that the charm
    was missing the code to trigger an upgrade after a change in
    openstack-origin so this change corrects that.

    Closes-Bug: #1968871
    Change-Id: Ie7ac1b0203d3a51cf3ff74ed8797be3f169cfd1c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/838548

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ironic-conductor/+/838548
Committed: https://opendev.org/openstack/charm-ironic-conductor/commit/d0e0c3a31dd36860d3af5965f4a052012f54b4a7
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit d0e0c3a31dd36860d3af5965f4a052012f54b4a7
Author: Liam Young <email address hidden>
Date: Thu Apr 14 16:47:26 2022 +0000

    Stop managing grub.cfg in Yoga

    From yoga onwards the ironic-conductor manges the grub.conf. This
    change ensure that the charm stops managing it. This change also
    ensures that the file permissions are set correctly prior to
    the upgrade to Yoga.

    While developing this change it became apparent that the charm
    was missing the code to trigger an upgrade after a change in
    openstack-origin so this change corrects that.

    Closes-Bug: #1968871
    Change-Id: Ie7ac1b0203d3a51cf3ff74ed8797be3f169cfd1c
    (cherry picked from commit a3b68bd8df73d37005bebc230e3c2f3343e39034)