Eoan fails to setup resources

[David Ames]

On Eoan, hacluster is failing to setup resources and has a mysterious "node1" added

crm status
Stack: corosync
Current DC: juju-fc5ea9-zaza-82b7f4ad7745-3 (version 2.0.1-9e909a5bdd) - partition with quorum
Last updated: Thu Sep 12 20:27:02 2019
Last change: Thu Sep 12 17:48:26 2019 by hacluster via crmd on juju-fc5ea9-zaza-82b7f4ad7745-2

4 nodes configured
4 resources configured

Online: [ juju-fc5ea9-zaza-82b7f4ad7745-1 juju-fc5ea9-zaza-82b7f4ad7745-2 juju-fc5ea9-zaza-82b7f4ad7745-3 ]
OFFLINE: [ node1 ]

Full list of resources:

 Clone Set: cl_ks_haproxy [res_ks_haproxy]
     Started: [ juju-fc5ea9-zaza-82b7f4ad7745-1 juju-fc5ea9-zaza-82b7f4ad7745-2 juju-fc5ea9-zaza-82b7f4ad7745-3 ]
     Stopped: [ node1 ]

[David Ames (thedac)]

Error logging:

ERROR: (unpack_config) warning: Blind faith: not fencing unseen nodes
ERROR: (unpack_config) warning: Blind faith: not fencing unseen nodes
ERROR: (unpack_config) warning: Blind faith: not fencing unseen nodes
ERROR: (unpack_config) warning: Blind faith: not fencing unseen nodes

[David Ames (thedac)]

ERROR: (unpack_config) warning: Blind faith: not fencing unseen nodes
ERROR: (unpack_config) warning: Blind faith: not fencing unseen nodes
ERROR: (unpack_config) warning: Blind faith: not fencing unseen nodes
ERROR: (unpack_config) warning: Blind faith: not fencing unseen nodes
ERROR: syntax in primitive: Attribute order error: timeout must appear before any instance attribute parsing 'primitive res_ks_cf9dea1_vip ocf:heartbeat:IPaddr2 params ip=10.5.253.30 op monitor depth=0 timeout=20s interval=10s'
active
ERROR: grp_ks_vips refers to missing object res_ks_cf9dea1_vip
ERROR: syntax in group: Expected at least 2 arguments near <group> parsing 'group grp_ks_vips'
ERROR: group (0): Expecting an element meta_attributes, got nothing ...

[David Ames (thedac)]

It seems the ordering of the parameters is significant in Eoan

https://github.com/juju/charm-helpers/pull/373

[David Ames (thedac)]

Cleaning up.

Charm helpers landed
https://github.com/juju/charm-helpers/pull/373

hacluster needs no changes itself.

charms.openstack still needs the fix, similar to charmhelpers.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/721794

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/721794
Committed: https://git.openstack.org/cgit/openstack/charm-interface-hacluster/commit/?id=67511b37878c74f69bf389193da1048d47c6e881
Submitter: Zuul
Branch: master

commit 67511b37878c74f69bf389193da1048d47c6e881
Author: Liam Young <email address hidden>
Date: Wed Apr 22 08:54:02 2020 +0000

    Resource parameter order is important on Eoan+

    Port of https://github.com/juju/charm-helpers/pull/373 to this
    interface for reactive charms. From the ch pull request:

    On Eoan we saw errors like:

    ERROR: syntax in primitive: Attribute order error: timeout must appear
    before any instance attribute parsing 'primitive res_ks_cf9dea1_vip
    ocfheartbeatIPaddr2 params ip=10.5.253.30 op monitor depth=0
    timeout=20s interval=10s'

    It would appear, that ordering matters, update resource config function
    to the correct order.

    Change-Id: I1f8a440fb0ad62192307946de42b9b176b3ef4c1
    Partial-Bug: #1843830