sas3ircu NRPE check results in error

[Xav Paice]

cs:hw-health-12
Running Focal

The check_sas3ircu.py plugin returns an error:

# /usr/local/lib/nagios/plugins/check_sas3ircu.py
Traceback (most recent call last):
  File "/usr/local/lib/nagios/plugins/check_sas3ircu.py", line 213, in <module>
    main(sys.argv[1:])
  File "/usr/local/lib/nagios/plugins/check_sas3ircu.py", line 208, in main
    data = parse_output(ARGS.input_file)
  File "/usr/local/lib/nagios/plugins/check_sas3ircu.py", line 55, in parse_output
    sections = sections_re.search(devices_raw.read()).groupdict()
AttributeError: 'NoneType' object has no attribute 'groupdict'

This results in the check showing as 'UNKNOWN' in Nagios, and the check being unusable.

The resource 'tools' was attached from charmstore, which is a 0 byte file due to tooling distribution limitations.

We need to update the error message in the charm, to confirm that the correct tools are indeed available in the resource, and installed, prior to adding the NRPE checks. Missing tools should set the charm to blocked status.

[Andrea Ieri (aieri)]

this is almost a duplicate of bug 1943736

[Eric Chen (eric-chen)]

This charm is no longer being actively maintained. Please consider using the new hardware-observer-operator instead. (https://github.com/canonical/hardware-observer-operator). This issue won't impact a lot to normal usage, therefore I will close it.