| 2017-01-26 15:05:07 |
Ryan Beisner |
bug |
|
|
added bug |
| 2017-01-26 15:15:46 |
Ryan Beisner |
bug task added |
|
charm-helpers |
|
| 2017-01-26 15:17:17 |
Ryan Beisner |
bug task added |
|
nova-cloud-controller (Juju Charms Collection) |
|
| 2017-01-26 16:24:18 |
Ryan Beisner |
description |
Presuming that after 'z' will come 'a' - with regard to distro codename, several charms are about to have unintended behavior due to the use of alpha comparison logic. The numeric version comparison should be used instead.
I've not done a full audit of all OpenStack Charms but that needs to be done as soon as possible, and associated with this bug.
Here are a some examples which need to be fixed:
https://github.com/openstack/charm-nova-compute/search?utf8=%E2%9C%93&q=distro_codename
distro_codename = lsb_release()['DISTRIB_CODENAME'].lower()
release = os_release('nova-common')
# NOTE(jamespage): deal with switch to systemd
if distro_codename < "wily":
distro_codename = lsb_release()['DISTRIB_CODENAME'].lower()
if distro_codename >= 'yakkety':
return LIBVIRTD_DAEMON
.
Here is an example of the safe way to do it:
https://github.com/openstack/charm-nova-cloud-controller/search?utf8=%E2%9C%93&q=DISTRIB_RELEASE&type=Code
bin_dir = os.path.join(git_pip_venv_dir(projects_yaml), 'bin')
# Use systemd init units/scripts from ubuntu wily onward
if lsb_release()['DISTRIB_RELEASE'] >= '15.10': |
Presuming that after 'z' will come 'a' - with regard to distro codename, several charms are about to have unintended behavior due to the use of alpha comparison logic. The numeric version comparison should be used instead.
I've not done a full audit of all OpenStack Charms but that needs to be done as soon as possible, and associated with this bug.
Here are a some examples which need to be fixed:
https://github.com/openstack/charm-nova-compute/search?utf8=%E2%9C%93&q=distro_codename
if distro_codename < "wily":
if distro_codename >= 'yakkety':
.
Here is an example of the safe way to do it:
https://github.com/openstack/charm-nova-cloud-controller/search?utf8=%E2%9C%93&q=DISTRIB_RELEASE&type=Code
if lsb_release()['DISTRIB_RELEASE'] >= '15.10': |
|
| 2017-01-26 16:43:58 |
James Page |
nova-compute (Juju Charms Collection): status |
New |
Triaged |
|
| 2017-01-26 16:44:00 |
James Page |
nova-compute (Juju Charms Collection): importance |
Undecided |
High |
|
| 2017-01-26 16:44:02 |
James Page |
nova-cloud-controller (Juju Charms Collection): importance |
Undecided |
High |
|
| 2017-01-26 16:44:05 |
James Page |
nova-cloud-controller (Juju Charms Collection): status |
New |
Triaged |
|
| 2017-01-26 16:44:07 |
James Page |
charm-helpers: importance |
Undecided |
High |
|
| 2017-01-26 16:44:09 |
James Page |
charm-helpers: status |
New |
Triaged |
|
| 2017-02-23 18:30:10 |
James Page |
charm-nova-compute: importance |
Undecided |
High |
|
| 2017-02-23 18:30:10 |
James Page |
charm-nova-compute: status |
New |
Triaged |
|
| 2017-02-23 18:30:12 |
James Page |
nova-compute (Juju Charms Collection): status |
Triaged |
Invalid |
|
| 2017-02-23 19:01:31 |
James Page |
charm-nova-cloud-controller: importance |
Undecided |
High |
|
| 2017-02-23 19:01:31 |
James Page |
charm-nova-cloud-controller: status |
New |
Triaged |
|
| 2017-02-23 19:01:33 |
James Page |
nova-cloud-controller (Juju Charms Collection): status |
Triaged |
Invalid |
|
| 2017-03-08 16:51:26 |
Alex Kavanagh |
charm-helpers: assignee |
|
Alex Kavanagh (ajkavanagh) |
|
| 2017-03-08 16:51:31 |
Alex Kavanagh |
charm-nova-cloud-controller: assignee |
|
Alex Kavanagh (ajkavanagh) |
|
| 2017-03-08 16:51:36 |
Alex Kavanagh |
charm-nova-compute: assignee |
|
Alex Kavanagh (ajkavanagh) |
|
| 2017-03-13 15:30:19 |
Alex Kavanagh |
branch linked |
|
lp:~ajkavanagh/charm-helpers/fix-alphanumerica-comparisons |
|
| 2017-03-20 11:41:27 |
Alex Kavanagh |
bug task added |
|
charm-keystone |
|
| 2017-03-20 11:41:39 |
Alex Kavanagh |
charm-keystone: importance |
Undecided |
High |
|
| 2017-03-20 11:41:42 |
Alex Kavanagh |
charm-keystone: assignee |
|
Alex Kavanagh (ajkavanagh) |
|
| 2017-03-20 11:41:53 |
Alex Kavanagh |
charm-keystone: status |
New |
In Progress |
|
| 2017-03-20 11:42:03 |
Alex Kavanagh |
charm-helpers: status |
Triaged |
Fix Committed |
|
| 2017-03-26 10:21:51 |
Alex Kavanagh |
charm-helpers: status |
Fix Committed |
In Progress |
|
| 2017-04-10 10:11:07 |
Alex Kavanagh |
charm-nova-cloud-controller: status |
Triaged |
In Progress |
|
| 2017-04-10 10:11:12 |
Alex Kavanagh |
charm-nova-compute: status |
Triaged |
In Progress |
|
| 2017-08-21 10:55:50 |
Alex Kavanagh |
charm-helpers: status |
In Progress |
Fix Released |
|
| 2017-08-21 10:56:10 |
Alex Kavanagh |
charm-keystone: status |
In Progress |
Fix Committed |
|
| 2017-08-21 10:56:15 |
Alex Kavanagh |
charm-keystone: milestone |
|
17.08 |
|
| 2017-08-21 10:56:23 |
Alex Kavanagh |
charm-nova-cloud-controller: status |
In Progress |
Fix Committed |
|
| 2017-08-21 10:56:27 |
Alex Kavanagh |
charm-nova-cloud-controller: milestone |
|
17.08 |
|
| 2017-08-21 10:56:41 |
Alex Kavanagh |
charm-nova-compute: status |
In Progress |
Fix Committed |
|
| 2017-08-21 10:56:45 |
Alex Kavanagh |
charm-nova-compute: milestone |
|
17.08 |
|
| 2017-09-12 19:13:46 |
James Page |
charm-nova-compute: status |
Fix Committed |
Fix Released |
|
| 2017-09-12 19:14:06 |
James Page |
charm-nova-cloud-controller: status |
Fix Committed |
Fix Released |
|
| 2017-09-12 19:14:26 |
James Page |
charm-keystone: status |
Fix Committed |
Fix Released |
|
