timeout value for _deploy in charmhelpers/contrib/amulet/deployment.py needs to be configurable

Bug #1605217 reported by Ryan Beisner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Charm Helpers
Fix Released
Medium
Ryan Beisner

Bug Description

The timeout value for _deploy in charmhelpers/contrib/amulet/deployment.py needs to be configurable

The error message raised when the timeout is hit should also announce how long it waited.

Tags: amulet uosci

Related branches

Revision history for this message
Ryan Beisner (1chb1n) wrote :

As right-now work-around, I've proposed this, as we had previously been carrying a similar hotpatch in CI to raise the existing 900s value to 2700s.

https://code.launchpad.net/~1chb1n/charm-helpers/increase-amulet-deploy-timeout/+merge/300750

But even with that, this needs to be revisited and properly plumbed through as a configurable parameter.

Changed in charm-helpers:
assignee: nobody → Ryan Beisner (1chb1n)
status: New → Confirmed
importance: Undecided → Medium
description: updated
Revision history for this message
Ryan Beisner (1chb1n) wrote :

This should just consume env var AMULET_SETUP_TIMEOUT if set. Same as amulet itself does @ https://github.com/juju/amulet/blob/master/amulet/deployer.py#L642

Will adjust MP...

Ryan Beisner (1chb1n)
Changed in charm-helpers:
status: Confirmed → Fix Committed
Ryan Beisner (1chb1n)
Changed in charm-helpers:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.