timeout value for _deploy in charmhelpers/contrib/amulet/deployment.py needs to be configurable
Bug #1605217 reported by
Ryan Beisner
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Charm Helpers |
Fix Released
|
Medium
|
Ryan Beisner |
Bug Description
The timeout value for _deploy in charmhelpers/
The error message raised when the timeout is hit should also announce how long it waited.
Related branches
lp:~1chb1n/charm-helpers/increase-amulet-deploy-timeout
- Liam Young (community): Approve
- Ryan Beisner (community): Needs Fixing
- James Page: Pending requested
-
Diff: 21 lines (+7/-3)1 file modifiedcharmhelpers/contrib/amulet/deployment.py (+7/-3)
Changed in charm-helpers: | |
status: | Confirmed → Fix Committed |
Changed in charm-helpers: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
As right-now work-around, I've proposed this, as we had previously been carrying a similar hotpatch in CI to raise the existing 900s value to 2700s.
https:/ /code.launchpad .net/~1chb1n/ charm-helpers/ increase- amulet- deploy- timeout/ +merge/ 300750
But even with that, this needs to be revisited and properly plumbed through as a configurable parameter.