Misleading error message ("Missing required data: database_password")

[Junien F]

Hi,

While looking at "juju debug-log" on an idle, working OpenStack cluster, I noticed disturbing messages :
unit-neutron-api-2[913]: 2016-05-03 12:10:07 INFO unit.neutron-api/2.juju-log server.go:268 Missing required data: database_password

After some investigation, it appears that these messages are bogus, and are due to the neutron_plugins() function, found at
https://bazaar.launchpad.net/~openstack-charmers/charms/trusty/neutron-api/trunk/view/head:/hooks/charmhelpers/contrib/openstack/neutron.py?start_revid=204#L99

This function instantiates a SharedDBContext with relation_prefix='neutron', however the actual relation is (in my cluster at least) not prefixed :

$ juju run --unit neutron-api/0 "relation-get -r shared-db:42 - mysql/2"
allowed_units: neutron-api/0 neutron-api/1 neutron-api/2
db_host: 10.X.Y.Z
password: <some random characters>
private-address: 10.X.Y.Z

As I understand it, the database bits are set up in neutron_api_utils.py ( https://bazaar.launchpad.net/~openstack-charmers/charms/trusty/neutron-api/trunk/view/head:/hooks/neutron_api_utils.py?start_revid=204#L143 ), so the all the "contexts" assignments in /hooks/charmhelpers/contrib/openstack/neutron.py can probably be removed.

For what it's worth, we're running with neutron packages version 2:7.0.3-0ubuntu1~cloud0

Thanks

[James Page (james-page)]

https://github.com/juju/charm-helpers/pull/16

[James Page (james-page)]

Fixed ages ago:

commit 9c67aa0fd2e495bb0b83be3b97f574fb38405b6d
Author: James Page <email address hidden>
Date: Wed Sep 27 18:55:13 2017 +0100

    Drop use of SharedDBContext in Neutron plugin config (#16)

    Database information has been configured at the neutron.conf
    level since the migration of neutron services out of the
    nova-cloud-controller charm.

    Drop all use of the SharedDBContext in plugin setup.