"E501 line too long" errors should not be ignored in charm-helpers directory

[Ryan Beisner]

E501 errors should not be ignored in the charm-helpers/ directory, as this can cause lint failures to sneak into projects which utilize code from charm-helpers/contrib.

Currently, when a reviewer runs `make lint` on the charm-helpers project, its Makefile ignores "E501 line too long" errors in the charmhelpers/, tests/, and tools/ directories.

It may be ok to continue to ignore these errors for the tests/ and tools/ directories as those should not affect other projects.

However, I suggest that we change the lint target to ignore nothing in the charm-helpers/ dir.

Example of offending code in charm-helpers/ directory:
http://paste.ubuntu.com/11702292/

[Ryan Beisner (1chb1n)]

If we do change this, then we will also need to do the lint cleanup as indicated in http://paste.ubuntu.com/11702292/.

If we decide not to change this, then charm-helper contributors and reviewers will need to manually run `flake8 charmhelpers` and sort through those results to make sure they're not adding to the oops list.

[Ryan Beisner (1chb1n)]

With regard to the openstack charms, they already ignore lint in hooks/charmhelpers altogether. But not tests/charmhelpers.
An alternate solution is to change every openstack charm to also ignore tests/charmhelpers via the make targets in those charms.

Current example from an openstack charm:
@flake8 --exclude hooks/charmhelpers hooks tests unit_tests

Would need to be changed to:
@flake8 --exclude hooks/charmhelpers,tests/charmhelpers hooks tests unit_tests

Seeking input and direction... please & thanks!