make lint fails with pep8 1.6.0 (2015-02-06)

Bug #1420963 reported by Billy Olsen
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Charm Helpers
Fix Released
High
Billy Olsen

Bug Description

A new version of pep8 (1.6.0) was recently released which introduces some new checks. There are various violations of the new rule checks for E402 and E731.

Some examples of this are as follows:

wolsen@chaps:~/work/openstack-charms/charm-helpers$ make test
Checking for Python syntax...
charmhelpers/contrib/python/version.py:22:1: E402 module level import not at top of file
charmhelpers/contrib/python/debug.py:24:1: E402 module level import not at top of file
charmhelpers/contrib/python/debug.py:25:1: E402 module level import not at top of file
charmhelpers/contrib/python/debug.py:27:1: E402 module level import not at top of file
charmhelpers/contrib/python/debug.py:28:1: E402 module level import not at top of file
charmhelpers/fetch/giturl.py:35:1: E402 module level import not at top of file
charmhelpers/contrib/ansible/__init__.py:178:9: E731 do not assign a lambda expression, use a def
...

These need to be cleaned up.

Related branches

Changed in charm-helpers:
assignee: nobody → Billy Olsen (billy-olsen)
status: New → In Progress
Changed in charm-helpers:
importance: Undecided → High
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.