Activity log for bug #1370053

Date Who What changed Old value New value Message
2014-09-16 13:15:05 Robert C Jennings bug added bug
2014-09-16 13:16:38 Launchpad Janitor branch linked lp:~rcj/charm-helpers/lp1370053
2014-09-16 13:17:16 Robert C Jennings bug added subscriber charmers
2015-05-05 16:43:51 Felipe Reyes charm-helpers: status New Incomplete
2015-06-02 13:51:41 Dan Watkins charm-helpers: assignee Dan Watkins (daniel-thewatkins)
2015-06-02 13:53:06 Dan Watkins summary storage.linux.util.is_device_mounted logic is swapped for device/partition storage.linux.util.is_device_mounted logic doesn't work for unpartitioned disks
2015-06-02 14:37:06 Dan Watkins description The is_device_mounted() function checks if the passed device is a partition and tailors the regex based on this. However, the search expressions were swapped and would fail. When a partition is provided, a match will only be found if the parent device is mounted. For example, if we call is_device_mounted(device='/dev/sda1') and '/dev/sda1' is in the mount command output, the result is false. Similarly, is_device_mounted(device='/dev/sda') and '/dev/sda' is in the mount command output, the result is false. Instead, if the device is /dev/sda1 and /dev/sda is in the mount output, we get a True result from the function. When passed a full disk device (e.g. /dev/sda) is_device_mounted() function checks the mount output for '/dev/sda[0-9]+'; this means it returns False if /dev/sda is mounted directly (rather than partitioned and mounted).
2015-06-02 14:37:10 Dan Watkins charm-helpers: status Incomplete New
2015-06-02 16:58:55 Dan Watkins branch unlinked lp:~rcj/charm-helpers/lp1370053
2015-06-02 17:02:27 Dan Watkins charm-helpers: status New In Progress
2015-06-02 17:03:57 Dan Watkins branch linked lp:~daniel-thewatkins/charm-helpers/lp1370053
2015-08-24 13:43:09 Dan Watkins charm-helpers: status In Progress Fix Released