config needs to be manually saved
Bug #1328396 reported by
Stuart Bishop
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Charm Helpers |
Fix Released
|
Undecided
|
Tim Van Steenburgh | ||
Bug Description
The new Config object returned by hookenv.config() requires an explicit call to the save method when the hook is completed successfully.
This should happen automatically when using the @hook decorator, and manual inocations of the save method deprecated.
Related branches
lp:~tvansteenburgh/charm-helpers/config-implicit-save
- Stuart Bishop (community): Approve
-
Diff: 278 lines (+87/-27)6 files modifiedcharmhelpers/core/hookenv.py (+28/-15)
charmhelpers/core/services/base.py (+3/-0)
docs/examples/config.rst (+0/-8)
tests/contrib/ansible/test_ansible.py (+5/-2)
tests/core/test_hookenv.py (+31/-0)
tests/core/test_services.py (+20/-2)
| Changed in charm-helpers: | |
| assignee: | nobody → Tim Van Steenburgh (tvansteenburgh) |
| status: | New → In Progress |
| Changed in charm-helpers: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
