fetch.add_source silently ignores unknown source

[Stuart Bishop]

fetch.add_source('https://example.com') silently does nothing, because it doesn't recognize it as a valid source.

[Adam Gandelman (gandelman-a)]

I believe the following MP addresses this

https://code.launchpad.net/~raharper/charm-helpers/fetch-support-https-private-ppa/+merge/202010

[Stuart Bishop (stub)]

This bug will be fixed when an unknown source causes an exception to be raised or a warning to be logged.

[Ryan Harper (raharper)]

When invoking apt-add-repository --yes, there is no validation of the url at all. Currently add_source rejects https, but the MP will address that.

Once add_source supports https urls, I don't think we can raise an exception when add-apt-repository is doing real work and doesn't error.

(foudres) ~ % grep -r example /etc/apt/sources.list*
(foudres) ~ % sudo apt-add-repository --yes "https://example.com" ; echo $?
0
(foudres) ~ % grep -r example /etc/apt/sources.list*
/etc/apt/sources.list:deb https://example.com saucy main
/etc/apt/sources.list:# deb-src https://example.com saucy main

[Stuart Bishop (stub)]

On Fri, Jan 17, 2014 at 10:11 PM, Ryan Harper
<email address hidden> wrote:
> When invoking apt-add-repository --yes, there is no validation of the
> url at all. Currently add_source rejects https, but the MP will address
> that.
>
> Once add_source supports https urls, I don't think we can raise an
> exception when add-apt-repository is doing real work and doesn't error.

I used https: in the example as it was the most obvious case.

We still can warn or raise an exception if add_source doesn't
understand its input at all, such as a misspelled keyword like
'proposed\n'.

--
Stuart Bishop <email address hidden>