check_corosync_rings results in check_cororings CRITICAL - No Rings Found on jammy

[Diko Parvanov]

Starting with jammy the corosync version (exhibited on 3.1.6-1ubuntu1) upgraded how corosync-cfgtool -s displays information about the rings, e.g.:

corosync 3.0.3-2ubuntu2.1
$ corosync-cfgtool -s
Printing link status.
Local node ID 1000
LINK ID 0
 addr = 10.10.12.10
 status = OK

corosync 3.1.6-1ubuntu1
$ /usr/sbin/corosync-cfgtool -s
Local node ID 1000, transport udpu
LINK ID 0
 addr = 10.140.48.13
 status:
  nodeid: 1000: localhost
  nodeid: 1001: connected
  nodeid: 1002: connected

The perl script fails to parse this new way and results in errors.

[Andrea Ieri (aieri)]

Added the charm-hacluster project as the same nrpe check exists in that repo.

After a cursory check it seems like there is no upstream for this nrpe plugin, so I'd suggest moving the plugin to a separate repo and importing it back as a submodule.

[JamesLin (jneo8)]

The check_corosync_rings checks was removed if distrib codename > eoan in ha-cluster

See: https://bugs.launchpad.net/charm-hacluster/+bug/1902919

[Andrea Ieri (aieri)]

@jneo8 Focal already uses corosync 3.0 and since this charm is used on deployments that are always configured with transport=udpu I think we should simply remove the check (and mark the hacluster portion of this bug report as a duplicate)

[Billy Olsen (billy-olsen)]

We can't mark the hacluster portion of the bug as duplicate but we can remove it as an affected project or mark it as invalid.