colocation constraint missing

[Liam Young]

On deploying percona cluster with hacluster subordinate the colocation constraint was missing from the pacemaker configuration.

The lead hacluster unit shows the following error:

2018-12-12 14:20:05 DEBUG hanode-relation-changed ERROR: element rsc_colocation: validity error : IDREF attribute with-rsc references an unknown ID "cl_mysql_monitor"
2018-12-12 14:20:05 DEBUG hanode-relation-changed element rsc_colocation: validity error : IDREF attribute with-rsc references an unknown ID "cl_mysql_monitor"
2018-12-12 14:20:05 DEBUG hanode-relation-changed Errors found during check: config not valid
2018-12-12 14:20:05 DEBUG hanode-relation-changed WARNING: colo_percona_cluster: resource cl_mysql_monitor does not exist

It looks like the charm attempts to create the constraint before the clone resource has been created. Subsequently manually running the ha-relation-changed hook in a debug-hooks session causes the constraint to be created.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624714
Committed: https://git.openstack.org/cgit/openstack/charm-hacluster/commit/?id=2ca245127e57f13aef9083d6a0e0fbef4c48041a
Submitter: Zuul
Branch: master

commit 2ca245127e57f13aef9083d6a0e0fbef4c48041a
Author: Liam Young <email address hidden>
Date: Wed Dec 12 14:43:56 2018 +0000

    Reorder colocation creation

    A colocation constraint may reference a clone resource (which
    percona-cluster charm does). So, the colocation must be created
    after the clones.

    Closes-Bug: #1808166
    Change-Id: I304df954b2f81477535fe64687af11055b932c27