OpenStack Manila Charm

Manila Charm has no way to change scheduler_default_filters

Bug #1998200 reported by Vern Hart
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Manila Charm
Fix Released
Wishlist
Jorge Merlino

Bug Description

Similar to the nova-cloud-controller and cinder charms, the manila charm needs a way to override the default filters.

Unlike the ncc and cinder charms, the manila charm doesn't have a config_flags option for plunking arbitrary configs into the [DEFAULT] section.

As expected, the config option is scheduler_default_filters and is in the [DEFAULT] section of manila.conf.

https://docs.openstack.org/manila/latest/configuration/shared-file-systems/config-options.html

One would expect a scheduler-default-filters charm config option to be able to modify this manila.conf option.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Thanks for reporting this Vern.

Agreed, there is prior art e.g. https://bugs.launchpad.net/bugs/1956727

Corey

Changed in charm-manila:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-manila/+/903627

Changed in charm-manila:
status: Triaged → In Progress
Jorge Merlino (jorge-merlino)
Changed in charm-manila:
assignee: nobody → Jorge Merlino (jorge-merlino)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (master)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/903627
Committed: https://opendev.org/openstack/charm-manila/commit/2cfb486f41dada7f30da6fa678b0d4bc34eb69db
Submitter: "Zuul (22348)"
Branch: master

commit 2cfb486f41dada7f30da6fa678b0d4bc34eb69db
Author: Jorge Merlino <email address hidden>
Date: Wed Dec 13 19:32:35 2023 -0300

    Add support to configure scheduler_default_filters

    Add new config option: `scheduler-default-filters`.
    This is unset by default, so manila retains the default value for
    scheduler_default_filters.

    Closes-Bug: #1998200
    Change-Id: I82eddf8f54d954f6d930265ec8612398f4cc90a0

Changed in charm-manila:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/charm-manila/+/908268

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/charm-manila/+/908269

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/charm-manila/+/908270

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/908268
Committed: https://opendev.org/openstack/charm-manila/commit/075802a34b4c3444df7e9d9aeb400b1bc1dece79
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 075802a34b4c3444df7e9d9aeb400b1bc1dece79
Author: Jorge Merlino <email address hidden>
Date: Wed Dec 13 19:32:35 2023 -0300

    Add support to configure scheduler_default_filters

    Add new config option: `scheduler-default-filters`.
    This is unset by default, so manila retains the default value for
    scheduler_default_filters.

    Closes-Bug: #1998200
    Change-Id: I82eddf8f54d954f6d930265ec8612398f4cc90a0
    (cherry picked from commit 2cfb486f41dada7f30da6fa678b0d4bc34eb69db)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/908269
Committed: https://opendev.org/openstack/charm-manila/commit/abbcc7287178c057f268f66ef3c97c699eb4a781
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit abbcc7287178c057f268f66ef3c97c699eb4a781
Author: Jorge Merlino <email address hidden>
Date: Wed Dec 13 19:32:35 2023 -0300

    Add support to configure scheduler_default_filters

    Add new config option: `scheduler-default-filters`.
    This is unset by default, so manila retains the default value for
    scheduler_default_filters.

    Closes-Bug: #1998200
    Change-Id: I82eddf8f54d954f6d930265ec8612398f4cc90a0
    (cherry picked from commit 2cfb486f41dada7f30da6fa678b0d4bc34eb69db)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-manila/+/908274

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/908270
Committed: https://opendev.org/openstack/charm-manila/commit/778edd7c09f6e7661031c13e9d35b5c9afd9d8aa
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 778edd7c09f6e7661031c13e9d35b5c9afd9d8aa
Author: Jorge Merlino <email address hidden>
Date: Wed Dec 13 19:32:35 2023 -0300

    Add support to configure scheduler_default_filters

    Add new config option: `scheduler-default-filters`.
    This is unset by default, so manila retains the default value for
    scheduler_default_filters.

    Closes-Bug: #1998200
    Change-Id: I82eddf8f54d954f6d930265ec8612398f4cc90a0
    (cherry picked from commit 2cfb486f41dada7f30da6fa678b0d4bc34eb69db)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/908274
Committed: https://opendev.org/openstack/charm-manila/commit/48b4e7b6953a70b32c6e6439532649bbe7c27d85
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 48b4e7b6953a70b32c6e6439532649bbe7c27d85
Author: Jorge Merlino <email address hidden>
Date: Wed Dec 13 19:32:35 2023 -0300

    Add support to configure scheduler_default_filters

    Add new config option: `scheduler-default-filters`.
    This is unset by default, so manila retains the default value for
    scheduler_default_filters.

    Closes-Bug: #1998200
    Change-Id: I82eddf8f54d954f6d930265ec8612398f4cc90a0
    (cherry picked from commit 2cfb486f41dada7f30da6fa678b0d4bc34eb69db)

tags: added: in-stable-yoga
Jorge Merlino (jorge-merlino)
Changed in charm-manila:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.