Upgrading charm doesn't update apt source resulting in apt update broken

[Giuseppe Petralia]

Upgrading the charm from revision 20 to revision 37 didn't upgrade the install_sources to 'deb https://packages.grafana.com/oss/deb stable main' in /etc/apt/source.list resulting in "apt update" broken. Also updating the source didn't fix the issue as the new gpg key defined in install_keys was not imported in the apt keyring.

This was on a xenial unit.

[Celia Wang (ziyiwang)]

Deploy the test env using the same bundle of xenial apt-install functional tests but switch grafana to cs:grafana-20.
grafana unit failed with hook "install" of:
E: Failed to fetch https://packagecloud.io/grafana/stable/debian/dists/stretch/main/binary-amd64/Packages 404 Not Found
E: Some index files failed to download. They have been ignored, or old ones used instead.

However, as I checked on grafana machine, install_sources 'deb https://packages.grafana.com/oss/deb stable main' does exist.
ubuntu@juju-a9cab7-5:~$ sudo cat /etc/apt/sources.list | grep oss
deb https://packages.grafana.com/oss/deb stable main

[Linda Guo (lihuiguo)]

hm, I can't reproduce this bug

--deployed grafana at version 20 on xenial:
App Version Status Scale Charm Channel Rev Exposed Message
grafana active 1 grafana 20 no Started grafana-server

Unit Workload Agent Machine Public address Ports Message
grafana/12* active idle 137 10.39.212.143 3000/tcp Started grafana-server

Machine State DNS Inst id Series AZ Message
137 started 10.39.212.143 juju-acd129-137 xenial Running

---upgraded it to version 37
App Version Status Scale Charm Channel Rev Exposed Message
grafana active 1 grafana 37 no Started grafana-server

Unit Workload Agent Machine Public address Ports Message
grafana/12* active idle 137 10.39.212.143 3000/tcp Started grafana-server

Machine State DNS Inst id Series AZ Message
137 started 10.39.212.143 juju-acd129-137 xenial Running

grafana status is OK, /etc/apt/source.list has install sources as following:

$ cat /etc/apt/sources.list |grep "packages.grafana.com/oss/deb "
deb https://packages.grafana.com/oss/deb stable main
# deb-src https://packages.grafana.com/oss/deb stable main

I will mark the bug as invalid for the time being, please reopen if it happens again

[Launchpad Janitor (janitor)]

[Expired for Grafana Charm because there has been no activity for 60 days.]