Grafana charm upgrade failed.

[aasbin]

Trying to grafana from cs:grafana-10 to cs:grafana-19. Unit went to the error state:

Command ran:

juju upgrade-charm grafana

Error:
Unit Workload Agent Machine Public address Ports Message
grafana/0* error idle 8 /removed hook failed: "update-status"

The logs:
2018-09-12 00:35:25 INFO juju-log Reactive main running for hook upgrade-charm
2018-09-12 00:35:25 INFO juju-log Initializing Snap Layer
2018-09-12 00:35:25 INFO juju-log Invoking reactive handler: reactive/snap.py:90:upgrade_charm
2018-09-12 00:35:25 INFO juju-log Invoking reactive handler: reactive/grafana.py:179:upgrade_charm
2018-09-12 00:35:25 INFO juju-log Invoking reactive handler: reactive/grafana.py:376:configure_sources
2018-09-12 00:35:26 INFO juju-log Found datasource: {'service_name': 'prometheus', 'description': 'Juju generated source', 'type': 'prometheus', 'url': 'http://10.28.2.28:9090'}
2018-09-12 00:35:26 INFO juju-log Datasource already exist, updating: prometheus - Juju generated source
2018-09-12 00:35:27 INFO juju-log Checking Dashboard Template: CephCluster.json.j2
2018-09-12 00:35:27 INFO juju-log Using Dashboard Template: CephCluster.json.j2
2018-09-12 00:35:27 ERROR juju-log Hook error:
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-grafana-0/.venv/lib/python3.4/site-packages/charms/reactive/__init__.py", line 73, in main
    bus.dispatch(restricted=restricted_mode)
  File "/var/lib/juju/agents/unit-grafana-0/.venv/lib/python3.4/site-packages/charms/reactive/bus.py", line 382, in dispatch
    _invoke(other_handlers)
  File "/var/lib/juju/agents/unit-grafana-0/.venv/lib/python3.4/site-packages/charms/reactive/bus.py", line 358, in _invoke
    handler.invoke()
  File "/var/lib/juju/agents/unit-grafana-0/.venv/lib/python3.4/site-packages/charms/reactive/bus.py", line 180, in invoke
    self._action(*args)
  File "/var/lib/juju/agents/unit-grafana-0/charm/reactive/grafana.py", line 391, in configure_sources
    generate_prometheus_dashboards(gf_adminpasswd, ds)
  File "/var/lib/juju/agents/unit-grafana-0/charm/reactive/grafana.py", line 546, in generate_prometheus_dashboards
    r = requests.post(post_req, json=dashboard_json, auth=('admin', gf_adminpasswd))
  File "/usr/lib/python3/dist-packages/requests/api.py", line 88, in post
    return request('post', url, data=data, **kwargs)
  File "/usr/lib/python3/dist-packages/requests/api.py", line 44, in request
    return session.request(method=method, url=url, **kwargs)
TypeError: request() got an unexpected keyword argument 'json'

2018-09-12 00:35:27 DEBUG upgrade-charm UPDATE DATA_SOURCE SET basic_auth_user = ?, basic_auth_password = ?, basic_auth = 0 ('', '')
2018-09-12 00:35:27 DEBUG upgrade-charm Traceback (most recent call last):
2018-09-12 00:35:27 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-grafana-0/charm/hooks/upgrade-charm", line 28, in <module>
2018-09-12 00:35:27 DEBUG upgrade-charm main()
2018-09-12 00:35:27 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-grafana-0/.venv/lib/python3.4/site-packages/charms/reactive/__init__.py", line 73, in main
2018-09-12 00:35:27 DEBUG upgrade-charm bus.dispatch(restricted=restricted_mode)
2018-09-12 00:35:27 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-grafana-0/.venv/lib/python3.4/site-packages/charms/reactive/bus.py", line 382, in dispatch
2018-09-12 00:35:27 DEBUG upgrade-charm _invoke(other_handlers)
2018-09-12 00:35:27 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-grafana-0/.venv/lib/python3.4/site-packages/charms/reactive/bus.py", line 358, in _invoke
2018-09-12 00:35:27 DEBUG upgrade-charm handler.invoke()
2018-09-12 00:35:27 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-grafana-0/.venv/lib/python3.4/site-packages/charms/reactive/bus.py", line 180, in invoke
2018-09-12 00:35:27 DEBUG upgrade-charm self._action(*args)
2018-09-12 00:35:27 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-grafana-0/charm/reactive/grafana.py", line 391, in configure_sources
2018-09-12 00:35:27 DEBUG upgrade-charm generate_prometheus_dashboards(gf_adminpasswd, ds)
2018-09-12 00:35:27 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-grafana-0/charm/reactive/grafana.py", line 546, in generate_prometheus_dashboards
2018-09-12 00:35:27 DEBUG upgrade-charm r = requests.post(post_req, json=dashboard_json, auth=('admin', gf_adminpasswd))
2018-09-12 00:35:27 DEBUG upgrade-charm File "/usr/lib/python3/dist-packages/requests/api.py", line 88, in post
2018-09-12 00:35:27 DEBUG upgrade-charm return request('post', url, data=data, **kwargs)
2018-09-12 00:35:27 DEBUG upgrade-charm File "/usr/lib/python3/dist-packages/requests/api.py", line 44, in request
2018-09-12 00:35:27 DEBUG upgrade-charm return session.request(method=method, url=url, **kwargs)
2018-09-12 00:35:27 DEBUG upgrade-charm TypeError: request() got an unexpected keyword argument 'json'
2018-09-12 00:35:27 ERROR juju.worker.uniter.operation runhook.go:114 hook "upgrade-charm" failed: exit status 1

[Xav Paice (xavpaice)]

This is one seen on Trusty, the solution is to add the Mitaka cloud archive and update python3-requests to the latest version.

[Drew Freiberger (afreiberger)]

Recommend solving with more unit and functional tests

[Xav Paice (xavpaice)]

Have been unable to reproduce this on recent versions of the charm, is it still an issue?

[Launchpad Janitor (janitor)]

[Expired for Grafana Charm because there has been no activity for 60 days.]