Upgrade to ussuri fails

[Liam Young]

Upgrading openstack from train to ussuri via the openstack origin config option (not action managed) fails with:

2020-05-19 17:36:09 ERROR juju-log Config not registered: /etc/glance/policy.yaml
2020-05-19 17:36:09 DEBUG config-changed Traceback (most recent call last):
2020-05-19 17:36:09 DEBUG config-changed File "/var/lib/juju/agents/unit-glance-0/charm/hooks/config-changed", line 612, in <module>
2020-05-19 17:36:09 DEBUG config-changed hooks.execute(sys.argv)
2020-05-19 17:36:09 DEBUG config-changed File "/var/lib/juju/agents/unit-glance-0/charm/charmhelpers/core/hookenv.py", line 943, in execute
2020-05-19 17:36:09 DEBUG config-changed self._hooks[hook_name]()
2020-05-19 17:36:09 DEBUG config-changed File "/var/lib/juju/agents/unit-glance-0/charm/charmhelpers/contrib/openstack/utils.py", line 1706, in wrapped_f
2020-05-19 17:36:09 DEBUG config-changed stopstart, restart_functions)
2020-05-19 17:36:09 DEBUG config-changed File "/var/lib/juju/agents/unit-glance-0/charm/charmhelpers/core/host.py", line 741, in restart_on_change_helper
2020-05-19 17:36:09 DEBUG config-changed r = lambda_f()
2020-05-19 17:36:09 DEBUG config-changed File "/var/lib/juju/agents/unit-glance-0/charm/charmhelpers/contrib/openstack/utils.py", line 1705, in <lambda>
2020-05-19 17:36:09 DEBUG config-changed (lambda: f(*args, **kwargs)), __restart_map_cache['cache'],
2020-05-19 17:36:09 DEBUG config-changed File "/var/lib/juju/agents/unit-glance-0/charm/charmhelpers/contrib/hardening/harden.py", line 93, in _harden_inner2
2020-05-19 17:36:09 DEBUG config-changed return f(*args, **kwargs)
2020-05-19 17:36:09 DEBUG config-changed File "/var/lib/juju/agents/unit-glance-0/charm/hooks/config-changed", line 403, in config_changed
2020-05-19 17:36:09 DEBUG config-changed update_image_location_policy(CONFIGS)
2020-05-19 17:36:09 DEBUG config-changed File "/var/lib/juju/agents/unit-glance-0/charm/hooks/glance_utils.py", line 647, in update_image_location_policy
2020-05-19 17:36:09 DEBUG config-changed configs.write(GLANCE_POLICY_YAML)
2020-05-19 17:36:09 DEBUG config-changed File "/var/lib/juju/agents/unit-glance-0/charm/charmhelpers/contrib/openstack/templating.py", line 319, in write
2020-05-19 17:36:09 DEBUG config-changed raise OSConfigException
2020-05-19 17:36:09 DEBUG config-changed charmhelpers.contrib.openstack.templating.OSConfigException
2020-05-19 17:36:09 ERROR juju.worker.uniter.operation runhook.go:132 hook "config-changed" failed: exit status 1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/729357

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/729357
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=eb47ec1147336209ba78b918660bf1dbae240867
Submitter: Zuul
Branch: master

commit eb47ec1147336209ba78b918660bf1dbae240867
Author: Liam Young <email address hidden>
Date: Tue May 19 19:10:36 2020 +0000

    Stop running register_configs at load time

    Stop running register_configs so it is not run unnecessarily.
    As part of this make sure that CONFIGS is refreshed after an
    upgrade as config files and contexts may have changed.

    Closes-Bug: #1879537

    Change-Id: Ib5e713194aac7275751329d0bd2dec13ececdf60

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/748019

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/20.08
Review: https://review.opendev.org/748118

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748019
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=d3bcd92616a23f04e6fce6a804045db6310ebb8a
Submitter: Zuul
Branch: master

commit d3bcd92616a23f04e6fce6a804045db6310ebb8a
Author: Felipe Reyes <email address hidden>
Date: Tue Aug 25 15:34:22 2020 -0400

    Use register_configs() in openstack-upgrade action

    CONFIGS global variable is no longer populated at load time instead is
    expected to use register_configs() function as pause/resume actions do.

    Change-Id: Id2504b40e09220c6cb6bb878727ffa181263e3f1
    Closes-Bug: #1887483
    Related-Bug: #1879537

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748118
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=5c5487ecc0737a91353d2d3e42472ed02240a58b
Submitter: Zuul
Branch: stable/20.08

commit 5c5487ecc0737a91353d2d3e42472ed02240a58b
Author: Felipe Reyes <email address hidden>
Date: Tue Aug 25 15:34:22 2020 -0400

    Use register_configs() in openstack-upgrade action

    CONFIGS global variable is no longer populated at load time instead is
    expected to use register_configs() function as pause/resume actions do.

    Change-Id: Id2504b40e09220c6cb6bb878727ffa181263e3f1
    Closes-Bug: #1887483
    Related-Bug: #1879537