glance <-> swift integration non-functional

[Andrew McLeod]

bionic (distro) deployment of glance + swift, error 'no module named swiftclient' - python2 swiftclient module is installed, python3-swiftclient is not. manually installing python3-swiftclient gets past this specific error

error log:

https://pastebin.ubuntu.com/p/5pCh6nnFJK/

[Corey Bryant (corey.bryant)]

It appears the problem is that the charm itself is py3 now is attempting to use the py2 swift client, python-swiftclient. hooks/glance_utils.py imports swiftclient. The charm needs to use the python3-swiftclient.

[James Page (james-page)]

Marking as Medium as most deployments don't use swift as the backend for glance (ceph is used).

This is fairly non-trivial to fix - Py3 versions of swiftclient are only present from Xenial onwards and we have to support trusty still. It also looks like the swift support is still using keystone v2 auth which will be broken in later releases which drop the v2 api.

[James Page (james-page)]

Preference is to switch to subprocess execution of the swiftclient rather than direct module calls.

[James Page (james-page)]

I highly doubt the swift integration functional in any way in a HA deployment:

        temp_url_key = pwgen(length=64)
        swift_connection.post_account(headers={'x-account-meta-temp-url-key':
                                               temp_url_key})

The temp-url key is generated per unit, rather than being set by the master glance unit and then being shared via leader storage.

[James Page (james-page)]

OK so we need to make a decision as to whether to spend the cycles to fix this support, or drop it all together.

[David Ames (thedac)]

@James,

That temp_url_key bit seems vestigial. Note that this is in the image-service (nova-compute,cinder to glance) relation and not the object-store (glance to swift) relation. Also the image-service contexts never check swift-temp-url-key key [0]. I also grepped through all the charms and all of charm-helpers and swift-temp-url-key is only found in the glance charm it is never consumed as far as I can tell.

Long story short, I think we can safely remove it.

[0] https://github.com/juju/charm-helpers/blob/master/charmhelpers/contrib/openstack/context.py#L751

[David Ames (thedac)]

Code speaks louder than words: https://review.openstack.org/620371

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620371
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=178d2701d640e656498e58131b529025a43d79b2
Submitter: Zuul
Branch: master

commit 178d2701d640e656498e58131b529025a43d79b2
Author: David Ames <email address hidden>
Date: Tue Nov 27 09:28:32 2018 -0800

    Remove vestigial swift_temp_url_key

    The swift-temp-url-key key on the image-service relation seems never to
    be consumed (see the ImageService context(s)). It appears to be
    vestigial and causes problems like Bug#1804023.

    As it is never consumed, this change removes it.

    Closes-Bug: #1804023

    Change-Id: I2cc19c550ebb1de09e66de8685d507f7db9e0f24

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.11
Review: https://review.openstack.org/623511

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/623511
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=f136e4d68cd84067b2ad97133b4f970503817b18
Submitter: Zuul
Branch: stable/18.11

commit f136e4d68cd84067b2ad97133b4f970503817b18
Author: David Ames <email address hidden>
Date: Tue Nov 27 09:28:32 2018 -0800

    Remove vestigial swift_temp_url_key

    The swift-temp-url-key key on the image-service relation seems never to
    be consumed (see the ImageService context(s)). It appears to be
    vestigial and causes problems like Bug#1804023.

    As it is never consumed, this change removes it.

    Closes-Bug: #1804023

    Change-Id: I2cc19c550ebb1de09e66de8685d507f7db9e0f24
    (cherry picked from commit 178d2701d640e656498e58131b529025a43d79b2)