Glance charm fails to install nrpe files

Bug #1779155 reported by Liam Young
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Glance Charm
Fix Released
High
Liam Young

Bug Description

The glance charm fails to install nrpe checks when related to nrpe. This appears to be due to it looking in the wrong place.

https://github.com/juju/charm-helpers/blob/master/charmhelpers/contrib/charmsupport/nrpe.py#L419

does not match where the nrpe files are in the glance charm.

Liam Young (gnuoy)
Changed in charm-glance:
assignee: nobody → Liam Young (gnuoy)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/578889

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-glance (master)

Reviewed: https://review.openstack.org/578889
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=4f935e39009e145210f7b5f53b0541fc7b02b7ac
Submitter: Zuul
Branch: master

commit 4f935e39009e145210f7b5f53b0541fc7b02b7ac
Author: Liam Young <email address hidden>
Date: Thu Jun 28 17:02:31 2018 +0000

    Point nrpe helper at nrpe files

    The glance charm has a slightly different layout compared to other
    OpenStack charms so nrpe.copy_nrpe_checks() needs to be pointed
    at an alternative location for the nrpe checks the charm provides.

    Change-Id: I3c7ce63069379008754bcba9201a3fc9c568853d
    Closes-Bug: #1779155

Changed in charm-glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-glance (stable/18.05)

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/579099

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-glance (stable/18.05)

Reviewed: https://review.openstack.org/579099
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=dc005063845f4197db20d06649b9f1ebb9a86b13
Submitter: Zuul
Branch: stable/18.05

commit dc005063845f4197db20d06649b9f1ebb9a86b13
Author: Liam Young <email address hidden>
Date: Thu Jun 28 17:02:31 2018 +0000

    Point nrpe helper at nrpe files

    The glance charm has a slightly different layout compared to other
    OpenStack charms so nrpe.copy_nrpe_checks() needs to be pointed
    at an alternative location for the nrpe checks the charm provides.

    Change-Id: I3c7ce63069379008754bcba9201a3fc9c568853d
    Closes-Bug: #1779155
    (cherry picked from commit 4f935e39009e145210f7b5f53b0541fc7b02b7ac)

David Ames (thedac)
Changed in charm-glance:
milestone: none → 18.08
James Page (james-page)
Changed in charm-glance:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.