API pagination returns HTTP unexpectedly with HTTPS enabled deployment

[Nobuto Murata]

In short, URL mismatch happends with multiple API tests with HTTPS.
"reference = u'http://.." != "actual = 'https://..."

- tempest.api.volume.test_volumes_list.VolumesListTestJSON.test_volume_list_details_pagination

$ refstack-client test -c ../tempest.conf -v -- \
    --regex tempest.api.volume.test_volumes_list.VolumesListTestJSON.test_volume_list_details_pagination

...

tempest.api.volume.test_volumes_list.VolumesListTestJSON.test_volume_list_details_pagination[id-e9138a2c-f67b-4796-8efa-635c196d01de]
-------------------------------------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "/home/ubuntu/deployment/refstack-client/.tempest/tempest/api/volume/test_volumes_list.py", line 350, in test_volume_list_details_pagination
        self._test_pagination('volumes', ids=self.volume_id_list, detail=True)
      File "/home/ubuntu/deployment/refstack-client/.tempest/tempest/api/volume/test_volumes_list.py", line 320, in _test_pagination
        self.assertEqual(next, response.response['content-location'])
      File "/home/ubuntu/deployment/refstack-client/.tempest/.venv/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
        self.assertThat(observed, matcher, message)
      File "/home/ubuntu/deployment/refstack-client/.tempest/.venv/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
        raise mismatch_error
    testtools.matchers._impl.MismatchError: !=:
    reference = u'http://cinder.example.com:8776/v2/4d38f2e952df497e80f4db8f3ec46acc/volumes/detail?limit=1&marker=e381d062-7edf-4d19-bec0-252562527ab4'
    actual = 'https://cinder.example.com:8776/v2/4d38f2e952df497e80f4db8f3ec46acc/volumes/detail?limit=1&marker=e381d062-7edf-4d19-bec0-252562527ab4'

[Nobuto Murata (nobuto)]

Adding the section below by hand into cinder.conf and restarting apache2 make the test pass.

====
[oslo_middleware]
enable_proxy_headers_parsing = True
====

We already have
RequestHeader set X-Forwarded-Proto "https"
in /etc/apache2/sites-enabled/openstack_https_frontend.conf.

enable_proxy_headers_parsing seems the equivalent config in backend services.

> enable_proxy_headers_parsing
> default=False,
> Whether the application is behind a proxy or not.
> This determines if the middleware should parse the
> headers or not.

[Nobuto Murata (nobuto)]

https://github.com/openstack/oslo.middleware/blob/3.35.0/oslo_middleware/http_proxy_to_wsgi.py#L18-L24

[Nobuto Murata (nobuto)]

Another reference: https://bugs.launchpad.net/devstack/+bug/1713731

[Nobuto Murata (nobuto)]

Subscribing ~field-high.

The issue may be revealed in some corner cases, but enabling enable_proxy_headers_parsing is essential to achieve OpenStack API deployment with SSL.

[Robert Ayres (robert-ayres)]

Apologies I've needed to drop working on this bug.

[Nobuto Murata (nobuto)]

@James, when you will work on this, can you please consider to add oslo_middleware/enable_proxy_headers_parsing as a common thing to all OpenStack API services? Cinder is an obvious case, but it would be beneficial to prevent potential corner cases in other services as well.

[Chris Gregan (cgregan)]

@jamespage do you have an update on this issue? It seems a bit stagnated at this point

[James Page (james-page)]

Picking this up this week (was away last week).

[James Page (james-page)]

OK so we've had some behavioral change over time; prior to oslo.middleware 2.9.0, parsing the setting the X-Forwarded-Proto header was done be default:

  https://github.com/openstack/oslo.middleware/commit/89b11a1c731bea4c74498c46a5e4272eef55f2f6#diff-c2c32b0bd2c128e701ce81483ff251b0

At 2.9.0, this behavior was changed to default to off; so Liberty deployments should DTRT; anything later needs this option set for API services.

As we always run with haproxy enabled, we can safely hardcode this to enabled in the templates.

[James Page (james-page)]

Version maps:

 python-oslo.middleware | 1.0.0-0ubuntu2~cloud0 | kilo | source
 python-oslo.middleware | 2.8.0-1~cloud0 | liberty | source
 python-oslo.middleware | 3.8.0-2~cloud0 | mitaka | source
 python-oslo.middleware | 3.19.0-0ubuntu1~cloud0 | newton | source
 python-oslo.middleware | 3.23.1-0ubuntu1.1~cloud0 | ocata | source
 python-oslo.middleware | 3.30.0-0ubuntu1.1~cloud0 | pike | source
 python-oslo.middleware | 3.34.0-0ubuntu1~cloud0 | queens | source

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/559692

[James Page (james-page)]

I've put up a test charm under:

  cs:~james-page/cinder-proxy-header

This includes the require config snippet to ensure that oslo.middleware parses any apache forwarded headers OK.

Nobuto - any chance you can test this out for me?

[James Page (james-page)]

Note that this will impact all API service charms - raising bug tasks.

[Nobuto Murata (nobuto)]

> At 2.9.0, this behavior was changed to default to off; so Liberty deployments should DTRT; anything later needs this option set for API services.
>
> As we always run with haproxy enabled, we can safely hardcode this to enabled in the templates.

I believe this is the latest upstream discussion:
https://bugs.launchpad.net/oslo.middleware/+bug/1590635
(they don't have an intention to re-enable it by default; so enabling it is on charms)

+1 for enabling it unconditionally in charms. While MAAS provider does not have firewall with `open-port`, it's on operators to configure ACLs properly to not allow access to the direct API service ports from untrusted zone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/559692
Committed: https://git.openstack.org/cgit/openstack/charm-cinder/commit/?id=50651ca6c08613b9861034ced6189a35430368bd
Submitter: Zuul
Branch: master

commit 50651ca6c08613b9861034ced6189a35430368bd
Author: James Page <email address hidden>
Date: Mon Apr 9 11:29:51 2018 +0100

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: I64e8c14123e5d12850902ce99490697ca4bb853d
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.02
Review: https://review.openstack.org/560304

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/560304
Committed: https://git.openstack.org/cgit/openstack/charm-cinder/commit/?id=cd3694bfc338b96f727ed93f8ff24d8ad20874ac
Submitter: Zuul
Branch: stable/18.02

commit cd3694bfc338b96f727ed93f8ff24d8ad20874ac
Author: James Page <email address hidden>
Date: Mon Apr 9 11:29:51 2018 +0100

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: I64e8c14123e5d12850902ce99490697ca4bb853d
    Closes-Bug: 1758675
    (cherry picked from commit 50651ca6c08613b9861034ced6189a35430368bd)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/563629

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/563630

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/563631

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/563633

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/563635

[Chris Gregan (cgregan)]

Field High SLA now requires that a estimated date for a fix is listed in the comments. Please provide this estimate for the open tasks.

[Xav Paice (xavpaice)]

I found that with Heat, I was unable to create/delete stacks because of this (i.e. not just in test).

This is 18.05 and Queens, heat was responding with an http url when it should be https:
RESP: [302] Date: Thu, 28 Jun 2018 01:20:20 GMT Server: Apache/2.4.18 (Ubuntu) Location: http://<blah>

Added the section to heat.conf from Nobuto's comment earlier on, restarted apache plus all the heat services, and things worked again.

[Nobuto Murata (nobuto)]

Patchset 2 of charm-heat has been uploaded. Rebased to the current master since it's been a while after originally proposed.
https://review.openstack.org/#/c/563630/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/578640

[Nobuto Murata (nobuto)]

charm-layer-openstack for reactive charms:
https://review.openstack.org/#/c/578645/

[Nobuto Murata (nobuto)]

I have rebased all of the previous patchsets and waiting for CI to vote:
https://review.openstack.org/#/q/topic:bug/1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563629
Committed: https://git.openstack.org/cgit/openstack/charm-keystone/commit/?id=f960109cb3adbdbd70d6020ac3727dd8db27383d
Submitter: Zuul
Branch: master

commit f960109cb3adbdbd70d6020ac3727dd8db27383d
Author: Liam Young <email address hidden>
Date: Mon Apr 23 13:52:30 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Includes charm helper sync to bring in oslo middleware
    template.

    Change-Id: I2ce75a4a2033d8d3c07bd9f7ce6e4f5f6d9488cf
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563633
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api/commit/?id=b53e83c465bab964421943547363989789c2057b
Submitter: Zuul
Branch: master

commit b53e83c465bab964421943547363989789c2057b
Author: Liam Young <email address hidden>
Date: Mon Apr 23 13:56:48 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Includes charm helper sync to bring in oslo middleware
    template.

    Change-Id: If1f3913967082618e7004d4b552d14fc2fe7b937
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563635
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=97f5a96163ec857bed230a01414daf60f11cd2dd
Submitter: Zuul
Branch: master

commit 97f5a96163ec857bed230a01414daf60f11cd2dd
Author: Liam Young <email address hidden>
Date: Mon Apr 23 13:59:32 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Includes charm helper sync to bring in oslo middleware
    template.

    Change-Id: I1232d089ab91572ec31c1b2172881165097af5fb
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563631
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=a7f029143fb63237c1fe4f91a965ce68b37695c3
Submitter: Zuul
Branch: master

commit a7f029143fb63237c1fe4f91a965ce68b37695c3
Author: Liam Young <email address hidden>
Date: Mon Apr 23 13:50:24 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: Id939a1873eb1e57b4b76771ad96c31a793cea923
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563630
Committed: https://git.openstack.org/cgit/openstack/charm-heat/commit/?id=432b83ae5dd461da542642043fa56a0c0261bad1
Submitter: Zuul
Branch: master

commit 432b83ae5dd461da542642043fa56a0c0261bad1
Author: Liam Young <email address hidden>
Date: Mon Apr 23 13:51:43 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Includes charm helper sync to bring in oslo middleware
    template.

    Change-Id: Icf13afd3a669d08a3254a362373ea7eeeb0d41f9
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/578640
Committed: https://git.openstack.org/cgit/openstack/charm-cinder/commit/?id=da7104c472324f17d2d3a47f918c29de5d921070
Submitter: Zuul
Branch: master

commit da7104c472324f17d2d3a47f918c29de5d921070
Author: Nobuto Murata <email address hidden>
Date: Thu Jun 28 12:18:41 2018 +0900

    Use charmhelpers template instead of hardcoding per charm

    Now that charmhelpers have the template with the same content so we can
    switch to it for future maintainability.

    Change-Id: Icfc7834de8215836b035bed98cdd64f479c5b2c9
    Related-Bug: #1758675

[Nobuto Murata (nobuto)]

Fix committed per https://review.openstack.org/#/c/578645/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563640
Committed: https://git.openstack.org/cgit/openstack/charm-barbican/commit/?id=1a0c66d5bacfde6c39441b19433f3f80ea60b5de
Submitter: Zuul
Branch: master

commit 1a0c66d5bacfde6c39441b19433f3f80ea60b5de
Author: Liam Young <email address hidden>
Date: Mon Apr 23 14:11:40 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: Id44d0f09c79a9464f4da47f1b81d720cfba56260
    Depends-On: https://review.openstack.org/578645
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563639
Committed: https://git.openstack.org/cgit/openstack/charm-designate/commit/?id=411a32e3856f4cc766ec82493e1deda667973520
Submitter: Zuul
Branch: master

commit 411a32e3856f4cc766ec82493e1deda667973520
Author: Liam Young <email address hidden>
Date: Mon Apr 23 14:08:48 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: Ic53e1e3a48ec316f5668a96e19f1c27493b86983
    Depends-On: https://review.openstack.org/578645
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563643
Committed: https://git.openstack.org/cgit/openstack/charm-gnocchi/commit/?id=2829a5c2a197bca45b4c998baa85510134d39e69
Submitter: Zuul
Branch: master

commit 2829a5c2a197bca45b4c998baa85510134d39e69
Author: Liam Young <email address hidden>
Date: Mon Apr 23 14:19:48 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: I2f8082c5a4b2e621a275d02db9123396d6de3971
    Depends-On: https://review.openstack.org/578645
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/563642
Committed: https://git.openstack.org/cgit/openstack/charm-aodh/commit/?id=29d15711832bc66809e2500a8ffe8ccd68719019
Submitter: Zuul
Branch: master

commit 29d15711832bc66809e2500a8ffe8ccd68719019
Author: Liam Young <email address hidden>
Date: Mon Apr 23 14:17:23 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: I704275a54961dc5d711f045684e8b9d5d24da206
    Depends-On: https://review.openstack.org/578645
    Closes-Bug: 1758675

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/582479

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/582480

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/582481

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/582483

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/582485

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/582486

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/582489

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/582490

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.05
Review: https://review.openstack.org/582491

[James Page (james-page)]

Cherry picks up for all master branch commits:

https://review.openstack.org/#/q/status:open+project:%22%255Eopenstack/charm-.*%22+branch:stable/18.05+topic:bug/1758675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582490
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api/commit/?id=2cb705d576e26d94931a97df7dbde5d016e02e94
Submitter: Zuul
Branch: stable/18.05

commit 2cb705d576e26d94931a97df7dbde5d016e02e94
Author: Liam Young <email address hidden>
Date: Mon Apr 23 13:56:48 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Includes charm helper sync to bring in oslo middleware
    template.

    Change-Id: If1f3913967082618e7004d4b552d14fc2fe7b937
    Closes-Bug: 1758675
    (cherry picked from commit b53e83c465bab964421943547363989789c2057b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582481
Committed: https://git.openstack.org/cgit/openstack/charm-barbican/commit/?id=5de14cd24ab80596d3d92aaa5be69cd1f387c72c
Submitter: Zuul
Branch: stable/18.05

commit 5de14cd24ab80596d3d92aaa5be69cd1f387c72c
Author: Liam Young <email address hidden>
Date: Mon Apr 23 14:11:40 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: Id44d0f09c79a9464f4da47f1b81d720cfba56260
    Depends-On: https://review.openstack.org/578645
    Closes-Bug: 1758675
    (cherry picked from commit 1a0c66d5bacfde6c39441b19433f3f80ea60b5de)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582485
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=9bc479d21e44ceb290d71f8a88d21b39c18bc75b
Submitter: Zuul
Branch: stable/18.05

commit 9bc479d21e44ceb290d71f8a88d21b39c18bc75b
Author: Liam Young <email address hidden>
Date: Mon Apr 23 13:50:24 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: Id939a1873eb1e57b4b76771ad96c31a793cea923
    Closes-Bug: 1758675
    (cherry picked from commit a7f029143fb63237c1fe4f91a965ce68b37695c3)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582480
Committed: https://git.openstack.org/cgit/openstack/charm-aodh/commit/?id=425249c057962d39cda253067145cae715a5cd86
Submitter: Zuul
Branch: stable/18.05

commit 425249c057962d39cda253067145cae715a5cd86
Author: Liam Young <email address hidden>
Date: Mon Apr 23 14:17:23 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: I704275a54961dc5d711f045684e8b9d5d24da206
    Depends-On: https://review.openstack.org/578645
    Closes-Bug: 1758675
    (cherry picked from commit 29d15711832bc66809e2500a8ffe8ccd68719019)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582479
Committed: https://git.openstack.org/cgit/openstack/charm-gnocchi/commit/?id=d05858386daf54e287c9b5a216c026cc7e8acc04
Submitter: Zuul
Branch: stable/18.05

commit d05858386daf54e287c9b5a216c026cc7e8acc04
Author: Liam Young <email address hidden>
Date: Mon Apr 23 14:19:48 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: I2f8082c5a4b2e621a275d02db9123396d6de3971
    Depends-On: https://review.openstack.org/578645
    Closes-Bug: 1758675
    (cherry picked from commit 2829a5c2a197bca45b4c998baa85510134d39e69)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582483
Committed: https://git.openstack.org/cgit/openstack/charm-designate/commit/?id=e928692d9f7091ac5128167c1a908f5854231dd6
Submitter: Zuul
Branch: stable/18.05

commit e928692d9f7091ac5128167c1a908f5854231dd6
Author: Liam Young <email address hidden>
Date: Mon Apr 23 14:08:48 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Change-Id: Ic53e1e3a48ec316f5668a96e19f1c27493b86983
    Depends-On: https://review.openstack.org/578645
    Closes-Bug: 1758675
    (cherry picked from commit 411a32e3856f4cc766ec82493e1deda667973520)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582489
Committed: https://git.openstack.org/cgit/openstack/charm-keystone/commit/?id=7003db0f48b819b135db80972277a6895abb8521
Submitter: Zuul
Branch: stable/18.05

commit 7003db0f48b819b135db80972277a6895abb8521
Author: Liam Young <email address hidden>
Date: Mon Apr 23 13:52:30 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Includes charm helper sync to bring in oslo middleware
    template.

    Change-Id: I2ce75a4a2033d8d3c07bd9f7ce6e4f5f6d9488cf
    Closes-Bug: 1758675
    (cherry picked from commit f960109cb3adbdbd70d6020ac3727dd8db27383d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582486
Committed: https://git.openstack.org/cgit/openstack/charm-heat/commit/?id=081bf625426c4feb4cdfa8b39ff1e3a11f5ea67c
Submitter: Zuul
Branch: stable/18.05

commit 081bf625426c4feb4cdfa8b39ff1e3a11f5ea67c
Author: Liam Young <email address hidden>
Date: Mon Apr 23 13:51:43 2018 +0000

    Enable proxy header parsing

    Ensure that oslo.middleware parses any proxy information
    forwarded from haproxy/apache with regards to protocol;
    this ensures that https connections are correctly detected.

    Includes charm helper sync to bring in oslo middleware
    template.

    Change-Id: Icf13afd3a669d08a3254a362373ea7eeeb0d41f9
    Closes-Bug: 1758675
    (cherry picked from commit 432b83ae5dd461da542642043fa56a0c0261bad1)

[Nobuto Murata (nobuto)]

Will update the bug status based on backport completion listed:
https://review.openstack.org/#/q/topic:bug/1758675

[OpenStack Infra (hudson-openstack)]

Change abandoned by James Page (<email address hidden>) on branch: stable/18.05
Review: https://review.openstack.org/582491
Reason: Will be superceeded by 18.08 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/cellsv2
Review: https://review.openstack.org/603115

[OpenStack Infra (hudson-openstack)]

Change abandoned by Liam Young (<email address hidden>) on branch: feature/cellsv2
Review: https://review.openstack.org/603115