Charm upgrade does not purge packages nor old version of script

[Frode Nordahl]

Recently we switched from distributing simplestreams as a snap as well as rename the charm sync helper script from glance-simplestreams-sync.py -> glance_simplestreams_sync.py.

However, on charm upgrade the python-simplestreams package is not purged, and the old script is left behind.

2021-05-13 22:05:10 DEBUG upgrade-charm Get:1 http://security.ubuntu.com/ubuntu bionic-security InRelease [88.7 kB]
2021-05-13 22:05:10 DEBUG upgrade-charm Hit:2 http://archive.ubuntu.com/ubuntu bionic InRelease
2021-05-13 22:05:10 DEBUG upgrade-charm Get:3 http://security.ubuntu.com/ubuntu bionic-security/main Sources [251 kB]
2021-05-13 22:05:10 DEBUG upgrade-charm Get:4 http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages [1725 kB]
2021-05-13 22:05:10 DEBUG upgrade-charm Get:5 http://archive.ubuntu.com/ubuntu bionic-updates InRelease [88.7 kB]
2021-05-13 22:05:10 DEBUG upgrade-charm Get:6 http://security.ubuntu.com/ubuntu bionic-security/main Translation-en [321 kB]
2021-05-13 22:05:10 DEBUG upgrade-charm Hit:7 http://ppa.launchpad.net/simplestreams-dev/trunk/ubuntu bionic InRelease
2021-05-13 22:05:11 DEBUG upgrade-charm Get:8 http://archive.ubuntu.com/ubuntu bionic-backports InRelease [74.6 kB]
2021-05-13 22:05:11 DEBUG upgrade-charm Get:9 http://archive.ubuntu.com/ubuntu bionic-updates/main Sources [510 kB]
2021-05-13 22:05:12 DEBUG upgrade-charm Get:10 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages [2068 kB]
2021-05-13 22:05:14 DEBUG upgrade-charm Get:11 http://archive.ubuntu.com/ubuntu bionic-updates/main Translation-en [413 kB]
2021-05-13 22:05:14 DEBUG upgrade-charm Get:12 http://archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages [1735 kB]
2021-05-13 22:05:18 DEBUG upgrade-charm Fetched 7275 kB in 5s (1503 kB/s)
2021-05-13 22:05:19 DEBUG upgrade-charm Reading package lists...
2021-05-13 22:05:19 INFO juju-log Installing python3-netaddr with options: ['--option=Dpkg::Options::=--force-confold']
2021-05-13 22:05:19 DEBUG upgrade-charm Reading package lists...
2021-05-13 22:05:19 DEBUG upgrade-charm Building dependency tree...
2021-05-13 22:05:19 DEBUG upgrade-charm Reading state information...
2021-05-13 22:05:19 DEBUG upgrade-charm Suggested packages:
2021-05-13 22:05:19 DEBUG upgrade-charm ipython3 python-netaddr-docs
2021-05-13 22:05:20 DEBUG upgrade-charm The following NEW packages will be installed:
2021-05-13 22:05:20 DEBUG upgrade-charm python3-netaddr
2021-05-13 22:05:21 DEBUG upgrade-charm 0 upgraded, 1 newly installed, 0 to remove and 96 not upgraded.
2021-05-13 22:05:21 DEBUG upgrade-charm Need to get 213 kB of archives.
2021-05-13 22:05:21 DEBUG upgrade-charm After this operation, 996 kB of additional disk space will be used.
2021-05-13 22:05:21 DEBUG upgrade-charm Get:1 http://archive.ubuntu.com/ubuntu bionic/main amd64 python3-netaddr all 0.7.19-1 [213 kB]
2021-05-13 22:05:23 DEBUG upgrade-charm Fetched 213 kB in 2s (89.9 kB/s)
2021-05-13 22:05:23 DEBUG upgrade-charm Selecting previously unselected package python3-netaddr.
(Reading database ... 40402 files and directories currently installed.)
2021-05-13 22:05:24 DEBUG upgrade-charm Preparing to unpack .../python3-netaddr_0.7.19-1_all.deb ...
2021-05-13 22:05:24 DEBUG upgrade-charm Unpacking python3-netaddr (0.7.19-1) ...
2021-05-13 22:05:25 DEBUG upgrade-charm Setting up python3-netaddr (0.7.19-1) ...
2021-05-13 22:05:26 INFO juju-log Installing python3-psutil with options: ['--option=Dpkg::Options::=--force-confold']
2021-05-13 22:05:27 DEBUG upgrade-charm Reading package lists...
2021-05-13 22:05:27 DEBUG upgrade-charm Building dependency tree...
2021-05-13 22:05:27 DEBUG upgrade-charm Reading state information...
2021-05-13 22:05:27 DEBUG upgrade-charm Suggested packages:
2021-05-13 22:05:27 DEBUG upgrade-charm python-psutil-doc
2021-05-13 22:05:27 DEBUG upgrade-charm The following NEW packages will be installed:
2021-05-13 22:05:27 DEBUG upgrade-charm python3-psutil
2021-05-13 22:05:27 DEBUG upgrade-charm 0 upgraded, 1 newly installed, 0 to remove and 96 not upgraded.
2021-05-13 22:05:27 DEBUG upgrade-charm Need to get 136 kB of archives.
2021-05-13 22:05:27 DEBUG upgrade-charm After this operation, 857 kB of additional disk space will be used.
2021-05-13 22:05:27 DEBUG upgrade-charm Get:1 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 python3-psutil amd64 5.4.2-1ubuntu0.1 [136 kB]
2021-05-13 22:05:28 DEBUG upgrade-charm Fetched 136 kB in 0s (306 kB/s)
2021-05-13 22:05:28 DEBUG upgrade-charm Selecting previously unselected package python3-psutil.
(Reading database ... 40442 files and directories currently installed.)
2021-05-13 22:05:28 DEBUG upgrade-charm Preparing to unpack .../python3-psutil_5.4.2-1ubuntu0.1_amd64.deb ...
2021-05-13 22:05:28 DEBUG upgrade-charm Unpacking python3-psutil (5.4.2-1ubuntu0.1) ...
2021-05-13 22:05:28 DEBUG upgrade-charm Setting up python3-psutil (5.4.2-1ubuntu0.1) ...
2021-05-13 22:05:33 DEBUG upgrade-charm Hit:1 http://security.ubuntu.com/ubuntu bionic-security InRelease
2021-05-13 22:05:33 DEBUG upgrade-charm Hit:2 http://archive.ubuntu.com/ubuntu bionic InRelease
2021-05-13 22:05:33 DEBUG upgrade-charm Hit:3 http://ppa.launchpad.net/simplestreams-dev/trunk/ubuntu bionic InRelease
2021-05-13 22:05:33 DEBUG upgrade-charm Hit:4 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
2021-05-13 22:05:33 DEBUG upgrade-charm Hit:5 http://archive.ubuntu.com/ubuntu bionic-backports InRelease
2021-05-13 22:05:37 DEBUG upgrade-charm Reading package lists...
2021-05-13 22:05:37 INFO juju-log creating config dir at /etc/glance-simplestreams-sync
2021-05-13 22:05:38 INFO juju-log creating config dir at /usr/share/glance-simplestreams-sync
2021-05-13 22:05:38 DEBUG upgrade-charm Hit:1 http://security.ubuntu.com/ubuntu bionic-security InRelease
2021-05-13 22:05:38 DEBUG upgrade-charm Hit:2 http://archive.ubuntu.com/ubuntu bionic InRelease
2021-05-13 22:05:38 DEBUG upgrade-charm Hit:3 http://ppa.launchpad.net/simplestreams-dev/trunk/ubuntu bionic InRelease
2021-05-13 22:05:38 DEBUG upgrade-charm Hit:4 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
2021-05-13 22:05:38 DEBUG upgrade-charm Hit:5 http://archive.ubuntu.com/ubuntu bionic-backports InRelease
2021-05-13 22:05:40 DEBUG upgrade-charm Reading package lists...
2021-05-13 22:05:40 INFO juju-log Installing ['python-glanceclient', 'python-yaml', 'python-keystoneclient', 'python-swiftclient', 'ubuntu-cloudimage-keyring', 'snapd'] with options: ['--option=Dpkg::Options::=--force-confold']
2021-05-13 22:05:40 DEBUG upgrade-charm Reading package lists...
2021-05-13 22:05:40 DEBUG upgrade-charm Building dependency tree...
2021-05-13 22:05:40 DEBUG upgrade-charm Reading state information...
2021-05-13 22:05:40 DEBUG upgrade-charm python-glanceclient is already the newest version (1:2.9.1-0ubuntu1).
2021-05-13 22:05:40 DEBUG upgrade-charm python-keystoneclient is already the newest version (1:3.15.0-0ubuntu1).
2021-05-13 22:05:40 DEBUG upgrade-charm python-swiftclient is already the newest version (1:3.5.0-0ubuntu1).
2021-05-13 22:05:40 DEBUG upgrade-charm python-yaml is already the newest version (3.12-1build2).
2021-05-13 22:05:40 DEBUG upgrade-charm snapd is already the newest version (2.48.3+18.04).
2021-05-13 22:05:40 DEBUG upgrade-charm The following packages will be upgraded:
2021-05-13 22:05:40 DEBUG upgrade-charm ubuntu-cloudimage-keyring
2021-05-13 22:05:41 DEBUG upgrade-charm 1 upgraded, 0 newly installed, 0 to remove and 95 not upgraded.
2021-05-13 22:05:41 DEBUG upgrade-charm Need to get 1740 B of archives.
2021-05-13 22:05:41 DEBUG upgrade-charm After this operation, 0 B of additional disk space will be used.
2021-05-13 22:05:41 DEBUG upgrade-charm Get:1 http://archive.ubuntu.com/ubuntu bionic-updates/universe amd64 ubuntu-cloudimage-keyring all 2018.09.18.1~18.04.2 [1740 B]
2021-05-13 22:05:41 DEBUG upgrade-charm Fetched 1740 B in 0s (8632 B/s)
(Reading database ... 40477 files and directories currently installed.)
2021-05-13 22:05:41 DEBUG upgrade-charm Preparing to unpack .../ubuntu-cloudimage-keyring_2018.09.18.1~18.04.2_all.deb ...
2021-05-13 22:05:41 DEBUG upgrade-charm Unpacking ubuntu-cloudimage-keyring (2018.09.18.1~18.04.2) over (2018.09.18.1~18.04.0) ...
2021-05-13 22:05:41 DEBUG upgrade-charm Setting up ubuntu-cloudimage-keyring (2018.09.18.1~18.04.2) ...
2021-05-13 22:05:43 INFO juju-log Installing snap(s) "simplestreams" with option(s) "--channel=stable"
2021-05-13 22:05:57 DEBUG upgrade-charm 2021-05-13T22:05:55Z INFO Waiting for automatic snapd restart...
2021-05-13 22:06:23 DEBUG upgrade-charm simplestreams 0.1.0-ff048fd from Canonical* installed
2021-05-13 22:06:23 INFO juju-log end install hook.
2021-05-13 22:06:23 INFO juju-log Nagios user not set up, nrpe checks not updated
2021-05-13 22:06:23 WARNING juju-log Package openstack-release has no installation candidate.
2021-05-13 22:06:25 INFO juju-log Registered config file: /etc/glance-simplestreams-sync/mirrors.yaml
2021-05-13 22:06:25 INFO juju-log Registered config file: /etc/glance-simplestreams-sync/identity.yaml
2021-05-13 22:06:25 INFO juju-log Generating template ctxt for simplestreams-image-service
2021-05-13 22:06:26 INFO juju-log Loaded template from templates/mirrors.yaml
2021-05-13 22:06:26 INFO juju-log Rendering from template: /etc/glance-simplestreams-sync/mirrors.yaml
2021-05-13 22:06:26 INFO juju-log Wrote template /etc/glance-simplestreams-sync/mirrors.yaml.
2021-05-13 22:06:26 DEBUG juju-log Generating template context for identity-service
2021-05-13 22:06:27 INFO juju-log Loaded template from templates/identity.yaml
2021-05-13 22:06:27 INFO juju-log Rendering from template: /etc/glance-simplestreams-sync/identity.yaml
2021-05-13 22:06:27 INFO juju-log Wrote template /etc/glance-simplestreams-sync/identity.yaml.
2021-05-13 22:06:28 INFO juju-log begin config-changed hook.
2021-05-13 22:06:28 WARNING juju-log Package openstack-release has no installation candidate.
2021-05-13 22:06:29 INFO juju-log Registered config file: /etc/glance-simplestreams-sync/mirrors.yaml
2021-05-13 22:06:29 INFO juju-log Registered config file: /etc/glance-simplestreams-sync/identity.yaml
2021-05-13 22:06:30 INFO juju-log Generating template ctxt for simplestreams-image-service
2021-05-13 22:06:30 INFO juju-log Loaded template from templates/mirrors.yaml
2021-05-13 22:06:30 INFO juju-log Rendering from template: /etc/glance-simplestreams-sync/mirrors.yaml
2021-05-13 22:06:30 INFO juju-log Wrote template /etc/glance-simplestreams-sync/mirrors.yaml.
2021-05-13 22:06:30 DEBUG juju-log Generating template context for identity-service
2021-05-13 22:06:31 INFO juju-log Loaded template from templates/identity.yaml
2021-05-13 22:06:31 INFO juju-log Rendering from template: /etc/glance-simplestreams-sync/identity.yaml
2021-05-13 22:06:32 INFO juju-log Wrote template /etc/glance-simplestreams-sync/identity.yaml.
2021-05-13 22:06:32 INFO juju-log Nagios user not set up, nrpe checks not updated
2021-05-13 22:06:32 INFO juju-log 'run' set to False, removing cron jobs