Designate-agent should be removed in Caracal

[Bartosz Woronicz]

Symptom: charm stuck in blocked state because of the service designate-agent failing

ubuntu@juju-8a251a-6-lxd-0:~$ systemctl status designate-agent
× designate-agent.service - OpenStack Designate DNSaaS Agent
     Loaded: loaded (/lib/systemd/system/designate-agent.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Mon 2024-05-13 10:32:50 UTC; 3h 38min ago
       Docs: man:designate-agent(1)
    Process: 9103 ExecStart=/etc/init.d/designate-agent systemd-start (code=exited, status=1/FAILURE)
   Main PID: 9103 (code=exited, status=1/FAILURE)
        CPU: 617ms

May 13 10:32:50 juju-8a251a-6-lxd-0 systemd[1]: designate-agent.service: Scheduled restart job, restart counter is at 10.
May 13 10:32:50 juju-8a251a-6-lxd-0 systemd[1]: Stopped OpenStack Designate DNSaaS Agent.

See the following details of the charm state:

App Version Status Scale Charm Channel Rev Exposed Message
designate caracal blocked 1 designate latest/edge 224 no Services not running that should be: designate-agent

The charm requires designate-agent service to be running, yet this one was removed in Caracal
Please see the description here:
https://docs.openstack.org/releasenotes/designate/2024.1.html
>Designate-agent removal is complete in this version of designate.

The service to be checked is defined as list in the code. Yet it should be handled for backward compatibility it should be removed from the list if the version is >= Caracal(2024.1)

See the code excerpt here:
https://opendev.org/openstack/charm-designate/src/branch/master/src/lib/charm/openstack/designate.py#L314

I also see that the package still exist while it should be removed
ubuntu@juju-8a251a-6-lxd-0:~$ apt-cache policy show designate-agent
designate-agent:
  Installed: 1:14.0.4-0ubuntu1
  Candidate: 1:18.0.0-0ubuntu1~cloud0
  Version table:
     1:18.0.0-0ubuntu1~cloud0 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu jammy-updates/caracal/main amd64 Packages

This package contained auto-generated service:
ubuntu@juju-8a251a-6-lxd-0:~$ dpkg -L designate-agent
/.
/etc
/etc/init.d
/etc/init.d/designate-agent
/lib
/lib/systemd
/lib/systemd/system
/lib/systemd/system/designate-agent.service
/usr
/usr/share
/usr/share/doc
/usr/share/doc/designate-agent
/usr/share/doc/designate-agent/copyright
/usr/share/doc/designate-agent/changelog.Debian.gz
ubuntu@juju-8a251a-6-lxd-0:~$ apt-cache policy show python3-designate
python3-designate:
  Installed: 1:18.0.0-0ubuntu1~cloud0
  Candidate: 1:18.0.0-0ubuntu1~cloud0
  Version table:
 *** 1:18.0.0-0ubuntu1~cloud0 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu jammy-updates/caracal/main amd64 Packages
        100 /var/lib/dpkg/status

Yet the actual binary used to be packaged as /usr/bin/designate-agent in python3-designate, while it is not now
ubuntu@juju-8a251a-6-lxd-0:~$ dpkg -L python3-designate|grep bin
/usr/bin
/usr/bin/designate-api
/usr/bin/designate-api-wsgi
/usr/bin/designate-central
/usr/bin/designate-manage
/usr/bin/designate-mdns
/usr/bin/designate-producer
/usr/bin/designate-rootwrap
/usr/bin/designate-sink
/usr/bin/designate-status
/usr/bin/designate-worker
/usr/lib/python3/dist-packages/designate/backend/impl_bind9.py
/usr/lib/python3/dist-packages/designate/tests/unit/backend/test_bind9.py

[Bartosz Woronicz (mastier1)]

This is related bug for the designate-agent package
https://bugs.launchpad.net/designate/+bug/2065597

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-designate/+/920754

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/920754
Committed: https://opendev.org/openstack/charm-designate/commit/c32bd7244e07d52152f70c9549fd53c2a9a3dca2
Submitter: "Zuul (22348)"
Branch: master

commit c32bd7244e07d52152f70c9549fd53c2a9a3dca2
Author: Alex Kavanagh <email address hidden>
Date: Wed May 29 15:51:56 2024 +0100

    Remove the designate-agent service/package install

    As of caracal [1] the designate-agent service has been removed. The
    designate-mdns service is used instead, which was enabled in a previous
    release. The default settings for the designate-mdns have been left as
    is.

    [1] https://docs.openstack.org/releasenotes/designate/2024.1.html

    func-test-pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/1213

    Change-Id: I1f3f15dff365df467379957fd5b96d6623496c86
    Closes-Bug: #2065596

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/charm-designate/+/920846

[Bartosz Woronicz (mastier1)]

I confirmed the fix worked

On Thu, May 30, 2024 at 6:30 PM OpenStack Infra <email address hidden>
wrote:

> Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/920754
> Committed:
> https://opendev.org/openstack/charm-designate/commit/c32bd7244e07d52152f70c9549fd53c2a9a3dca2
> Submitter: "Zuul (22348)"
> Branch: master
>
> commit c32bd7244e07d52152f70c9549fd53c2a9a3dca2
> Author: Alex Kavanagh <email address hidden>
> Date: Wed May 29 15:51:56 2024 +0100
>
> Remove the designate-agent service/package install
>
> As of caracal [1] the designate-agent service has been removed. The
> designate-mdns service is used instead, which was enabled in a previous
> release. The default settings for the designate-mdns have been left as
> is.
>
> [1] https://docs.openstack.org/releasenotes/designate/2024.1.html
>
> func-test-pr:
> https://github.com/openstack-charmers/zaza-openstack-tests/pull/1213
>
> Change-Id: I1f3f15dff365df467379957fd5b96d6623496c86
> Closes-Bug: #2065596
>
>
> ** Changed in: charm-designate
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/2065596
>
> Title:
> Designate-agent should be removed in Caracal
>
> Status in OpenStack Designate Charm:
> Fix Committed
>
> Bug description:
> Symptom: charm stuck in blocked state because of the service
> designate-agent failing
>
> ubuntu@juju-8a251a-6-lxd-0:~$ systemctl status designate-agent
> × designate-agent.service - OpenStack Designate DNSaaS Agent
> Loaded: loaded (/lib/systemd/system/designate-agent.service;
> enabled; vendor preset: enabled)
> Active: failed (Result: exit-code) since Mon 2024-05-13 10:32:50
> UTC; 3h 38min ago
> Docs: man:designate-agent(1)
> Process: 9103 ExecStart=/etc/init.d/designate-agent systemd-start
> (code=exited, status=1/FAILURE)
> Main PID: 9103 (code=exited, status=1/FAILURE)
> CPU: 617ms
>
> May 13 10:32:50 juju-8a251a-6-lxd-0 systemd[1]: designate-agent.service:
> Scheduled restart job, restart counter is at 10.
> May 13 10:32:50 juju-8a251a-6-lxd-0 systemd[1]: Stopped OpenStack
> Designate DNSaaS Agent.
>
> See the following details of the charm state:
>
> App Version Status Scale Charm
> Channel Rev Exposed Message
> designate caracal blocked 1 designate
> latest/edge 224 no Services not running that should be:
> designate-agent
>
>
> The charm requires designate-agent service to be running, yet this one
> was removed in Caracal
> Please see the description here:
> https://docs.openstack.org/releasenotes/designate/2024.1.html
> >Designate-agent removal is complete in this version of designate.
>
> The service to be checked is defined as list in the code. Yet it
> should be handled for backward compatibility it should be removed from
> the list if the version is >= Caracal(2024.1)
>
> See the code excerpt here:
>
> https://opendev.org/openstack/charm-designate/src/branch/master/src/lib/charm/openstack/designate.py#L3...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/920846
Committed: https://opendev.org/openstack/charm-designate/commit/fc3225b1ef297361506ab22827ea9fac70fe75fd
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit fc3225b1ef297361506ab22827ea9fac70fe75fd
Author: Alex Kavanagh <email address hidden>
Date: Wed May 29 15:51:56 2024 +0100

    Remove the designate-agent service/package install

    As of caracal [1] the designate-agent service has been removed. The
    designate-mdns service is used instead, which was enabled in a previous
    release. The default settings for the designate-mdns have been left as
    is.

    [1] https://docs.openstack.org/releasenotes/designate/2024.1.html

    func-test-pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/1214

    Change-Id: I1f3f15dff365df467379957fd5b96d6623496c86
    Closes-Bug: #2065596
    (cherry picked from commit c32bd7244e07d52152f70c9549fd53c2a9a3dca2)