OpenStack Designate Charm

Charm exposes the use-internal-endpoints config option but does nothing with it

Bug #1995188 reported by Tiago Pasqualini da Silva
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Designate Charm
Fix Committed
Undecided
Unassigned

Bug Description

The designate charm inherits the use-internal-endpoints config option from the openstack layer, but currently it is not being used, as the only endpoint ever being exposed is the public one [1].

[1] https://github.com/openstack/charm-designate/blob/master/src/reactive/designate_handlers.py#L245

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-designate/+/862976

Changed in charm-designate:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (master)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/862976
Committed: https://opendev.org/openstack/charm-designate/commit/8a4940bbb108124246ad3ae830964cf58dfc9ec3
Submitter: "Zuul (22348)"
Branch: master

commit 8a4940bbb108124246ad3ae830964cf58dfc9ec3
Author: Tiago Pasqualini <email address hidden>
Date: Sat Oct 29 21:53:15 2022 -0300

    Add check to expose internal endpoints

    Currently, the charm ignores the use-internal-endpoints config
    option that is being inherited from the Openstack Layer. This
    patch adds a check to ensure that the internal endpoint is exposed
    if this is set to True.

    Closes-bug: #1995188
    Change-Id: I48a04ac619204ba109d87ca05de7cbe308592486

Changed in charm-designate:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/charm-designate/+/865557

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/865557
Committed: https://opendev.org/openstack/charm-designate/commit/4d50f9ab40c8948771a7338949a84a3899c426d7
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 4d50f9ab40c8948771a7338949a84a3899c426d7
Author: Tiago Pasqualini <email address hidden>
Date: Sat Oct 29 21:53:15 2022 -0300

    Add check to expose internal endpoints

    Currently, the charm ignores the use-internal-endpoints config
    option that is being inherited from the Openstack Layer. This
    patch adds a check to ensure that the internal endpoint is exposed
    if this is set to True.

    Closes-bug: #1995188
    Change-Id: I48a04ac619204ba109d87ca05de7cbe308592486
    (cherry picked from commit 8a4940bbb108124246ad3ae830964cf58dfc9ec3)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-designate/+/866009

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/866009
Committed: https://opendev.org/openstack/charm-designate/commit/1a0d3f4765ad359f6c9dd6d384377c859e7a36fe
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 1a0d3f4765ad359f6c9dd6d384377c859e7a36fe
Author: Tiago Pasqualini <email address hidden>
Date: Sat Oct 29 21:53:15 2022 -0300

    Add check to expose internal endpoints

    Currently, the charm ignores the use-internal-endpoints config
    option that is being inherited from the Openstack Layer. This
    patch adds a check to ensure that the internal endpoint is exposed
    if this is set to True.

    Closes-bug: #1995188
    Change-Id: I48a04ac619204ba109d87ca05de7cbe308592486
    (cherry picked from commit 8a4940bbb108124246ad3ae830964cf58dfc9ec3)
    (cherry picked from commit 4d50f9ab40c8948771a7338949a84a3899c426d7)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-designate/+/866667

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-designate (stable/wallaby)

Change abandoned by "Rodrigo Barbieri <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-designate/+/866667
Reason: wrong cherrypick

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-designate/+/866668

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-designate/+/869461

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-designate/+/869462

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/866668
Committed: https://opendev.org/openstack/charm-designate/commit/20381223c8a77cd021da74289af3a095da0de53f
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 20381223c8a77cd021da74289af3a095da0de53f
Author: Tiago Pasqualini <email address hidden>
Date: Sat Oct 29 21:53:15 2022 -0300

    Add check to expose internal endpoints

    Currently, the charm ignores the use-internal-endpoints config
    option that is being inherited from the Openstack Layer. This
    patch adds a check to ensure that the internal endpoint is exposed
    if this is set to True.

    Closes-bug: #1995188
    Change-Id: I48a04ac619204ba109d87ca05de7cbe308592486
    (cherry picked from commit 8a4940bbb108124246ad3ae830964cf58dfc9ec3)
    (cherry picked from commit 4d50f9ab40c8948771a7338949a84a3899c426d7)
    (cherry picked from commit 1a0d3f4765ad359f6c9dd6d384377c859e7a36fe)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/866667
Committed: https://opendev.org/openstack/charm-designate/commit/9caf724caae86fdf474edc56eb280307521a6049
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9caf724caae86fdf474edc56eb280307521a6049
Author: Tiago Pasqualini <email address hidden>
Date: Sat Oct 29 21:53:15 2022 -0300

    Add check to expose internal endpoints

    Currently, the charm ignores the use-internal-endpoints config
    option that is being inherited from the Openstack Layer. This
    patch adds a check to ensure that the internal endpoint is exposed
    if this is set to True.

    Closes-bug: #1995188
    Change-Id: I48a04ac619204ba109d87ca05de7cbe308592486
    (cherry picked from commit 8a4940bbb108124246ad3ae830964cf58dfc9ec3)
    (cherry picked from commit 4d50f9ab40c8948771a7338949a84a3899c426d7)
    (cherry picked from commit 1a0d3f4765ad359f6c9dd6d384377c859e7a36fe)
    (cherry picked from commit 20381223c8a77cd021da74289af3a095da0de53f)

tags: added: in-stable-wallaby
tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/869461
Committed: https://opendev.org/openstack/charm-designate/commit/ace9be35cbb30a3f2bcd941496e7bb122e380af3
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit ace9be35cbb30a3f2bcd941496e7bb122e380af3
Author: Tiago Pasqualini <email address hidden>
Date: Sat Oct 29 21:53:15 2022 -0300

    Add check to expose internal endpoints

    Currently, the charm ignores the use-internal-endpoints config
    option that is being inherited from the Openstack Layer. This
    patch adds a check to ensure that the internal endpoint is exposed
    if this is set to True.

    Closes-bug: #1995188
    Change-Id: I48a04ac619204ba109d87ca05de7cbe308592486
    (cherry picked from commit 8a4940bbb108124246ad3ae830964cf58dfc9ec3)
    (cherry picked from commit 4d50f9ab40c8948771a7338949a84a3899c426d7)
    (cherry picked from commit 1a0d3f4765ad359f6c9dd6d384377c859e7a36fe)
    (cherry picked from commit 20381223c8a77cd021da74289af3a095da0de53f)
    (cherry picked from commit 9caf724caae86fdf474edc56eb280307521a6049)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/869462
Committed: https://opendev.org/openstack/charm-designate/commit/275a77acb68f1c0e5dd704e5a49c6ae4510e1b04
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 275a77acb68f1c0e5dd704e5a49c6ae4510e1b04
Author: Tiago Pasqualini <email address hidden>
Date: Sat Oct 29 21:53:15 2022 -0300

    Add check to expose internal endpoints

    Currently, the charm ignores the use-internal-endpoints config
    option that is being inherited from the Openstack Layer. This
    patch adds a check to ensure that the internal endpoint is exposed
    if this is set to True.

    Closes-bug: #1995188
    Change-Id: I48a04ac619204ba109d87ca05de7cbe308592486
    (cherry picked from commit 8a4940bbb108124246ad3ae830964cf58dfc9ec3)
    (cherry picked from commit 4d50f9ab40c8948771a7338949a84a3899c426d7)
    (cherry picked from commit 1a0d3f4765ad359f6c9dd6d384377c859e7a36fe)
    (cherry picked from commit 20381223c8a77cd021da74289af3a095da0de53f)
    (cherry picked from commit 9caf724caae86fdf474edc56eb280307521a6049)
    (cherry picked from commit ace9be35cbb30a3f2bcd941496e7bb122e380af3)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.