vhost rendering for openstack_https_frontend.conf is not network space aware, still requires obsolete os-*-network configs

[Nobuto Murata]

This may be a dup of LP: #1745389 and worth to try the patchset: https://review.openstack.org/#/c/549134/
However, I'm not 100% sure so opening another one just to be safe and attach my test case.

Charm revision:
https://api.jujucharms.com/charmstore/v5/aodh-12/archive/repo-info
commit-sha-1: d7caff3b148cabf003f5307983eb988f847ea871
commit-short: d7caff3
branch: HEAD
remote: https://github.com/openstack/charm-aodh

How to reproduce:
1. prepare multiple network spaces in MAAS

 $ juju spaces
Space Subnets
space-first 192.168.151.0/24
space-second 192.168.152.0/24
undefined 10.0.8.0/24
              192.168.122.0/24

2. deploy OpenStack reactive charm (e.g. aodh) with multiple spaces and SSL

 $ juju deploy ./bundle.yaml (attached)

3. Check the rendered /etc/apache2/sites-enabled/openstack_https_frontend.conf file to see if it has multiple vhosts from each network space.

 $ juju ssh aodh/0 -- cat /etc/apache2/sites-enabled/openstack_https_frontend.conf

[expected]
Listen 8032
<VirtualHost 192.168.151.X:8032>
...
</VirtualHost>
<VirtualHost 192.168.152.X:8032>
...
</VirtualHost>

[actual]
Listen 8032
<VirtualHost 192.168.151.X:8032>
...
</VirtualHost>
<VirtualHost 192.168.151.X:8032>
...
</VirtualHost>

^^^ no binding for space-second=192.168.152.0/24

WORKAROUND:
set obsolete os-public-network, os-internal-network, os-admin-network explicitly in charm config.

[Nobuto Murata (nobuto)]

Subscribing Canonical's ~field-high.

While it has a workaround, setting os-*-network config in charms are deprecated AFAIU. This bug affects all deployments with SSL + multiple network bindings in OpenStack reactive charms. I'd like to request accelerating the gerrit review[1] from engineering side, and if it requires some modifications, I'd like to ask engineering team takes over writing another round of patchsets.

[1] https://review.openstack.org/#/c/549134/

[Chris Gregan (cgregan)]

Field High SLA now requires that a estimated date for a fix is listed in the comments. Please provide this estimate for the open tasks.

[Ryan Beisner (1chb1n)]

CI is failing on the proposed patch; current status of the bug is that we are triaging. There is no way to give an estimated date at this time. We will update as soon as we know more. Thank you.

[Ryan Beisner (1chb1n)]

Patchset CI issues are resolved. The proposed change is ready for review.

[Ryan Beisner (1chb1n)]

Next step is to reproduce and confirm the bug, also to review the proposed patch.

[James Page (james-page)]

I provided some feedback on the review. I can see exactly how the reactive charms don't honor the network space bindings if used.

[Seyeong Kim (seyeongkim)]

I confirmed that this [1] patch fixes
VirtualHost issue mentioned in desc.

[Seyeong Kim (seyeongkim)]

[1] https://review.openstack.org/#/c/549134/

[Seyeong Kim (seyeongkim)]

sorry for seprated comment.

I tested this with aodh charm

[Frode Nordahl (fnordahl)]

Removed charms.openstack target as that was fixed in bug #1745389

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/567748

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/567749

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/567750

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/567750
Committed: https://git.openstack.org/cgit/openstack/charm-designate/commit/?id=a07f38d0b8798d1f7f9596ebeb06f8aac6c7c25d
Submitter: Zuul
Branch: master

commit a07f38d0b8798d1f7f9596ebeb06f8aac6c7c25d
Author: Frode Nordahl <email address hidden>
Date: Fri May 11 08:08:48 2018 +0200

    Rebuild to pull in charms.openstack

    Pull in fix for rendering Apache VirtualHost correctly
    when charm is bound to network spaces.

    Change-Id: Ibffa77f8cde39114dc990b345120f55ff83d63d3
    Related-Bug: #1745389
    Closes-Bug: #1769973

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/567748
Committed: https://git.openstack.org/cgit/openstack/charm-gnocchi/commit/?id=6307620743a3ea4634d30d10ddd61a82455f333c
Submitter: Zuul
Branch: master

commit 6307620743a3ea4634d30d10ddd61a82455f333c
Author: Frode Nordahl <email address hidden>
Date: Fri May 11 08:03:13 2018 +0200

    Rebuild to pull in charms.openstack

    Pull in fix for rendering Apache VirtualHost correctly
    when charm is bound to network spaces.

    Change-Id: I5c754feff3f0e9babc9a41ab70d3546c44db0ab9
    Related-Bug: #1745389
    Closes-Bug: #1769973

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/567749
Committed: https://git.openstack.org/cgit/openstack/charm-aodh/commit/?id=f500c7869efd8a701866843b8ddfc39561e51efb
Submitter: Zuul
Branch: master

commit f500c7869efd8a701866843b8ddfc39561e51efb
Author: Frode Nordahl <email address hidden>
Date: Fri May 11 08:08:29 2018 +0200

    Rebuild to pull in charms.openstack

    Pull in fix for rendering Apache VirtualHost correctly
    when charm is bound to network spaces.

    Change-Id: If6ff6897b54a13a4777480a4240e3f814d3f22d8
    Related-Bug: #1745389
    Closes-Bug: #1769973

[Nobuto Murata (nobuto)]

https://docs.openstack.org/charm-guide/latest/release-schedule.html#stable-charm-release
> 18.05 Stable Charm Release
> Freeze Tue, May 15, 2018
> Release Thu, May 24, 2018

In case it does not happen on that date, please consider a stable backport separately.