designate is blocked with nameservers must be set because queens charm code is running against pike deploy

[Ashley Lai]

 designate/0:
        workload-status:
          current: blocked
          message: nameservers must be set

The config option nameservers is now required in the designate -next charm cs:~openstack-charmers-next/designate-70 ? We had a passing run using designate-68.

Also there is error in the designate log unit-designate-0.log

2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 CRITICAL designate [designate-manage - - - - -] Unhandled error: InvalidObject: Provided object is not valid. Got a TypeError with message 'NoneType' object is not iterable
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate Traceback (most recent call last):
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate File "/usr/bin/designate-manage", line 10, in <module>
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate sys.exit(main())
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate File "/usr/lib/python2.7/dist-packages/designate/cmd/manage.py", line 132, in main
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate fn(*fn_args)
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate File "/usr/lib/python2.7/dist-packages/designate/manage/pool.py", line 143, in update
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate pool = DesignateAdapter.parse('YAML', xpool, pool)
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate File "/usr/lib/python2.7/dist-packages/designate/objects/adapters/base.py", line 176, in parse
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate values, output_object, *args, **kwargs)
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate File "/usr/lib/python2.7/dist-packages/designate/objects/adapters/base.py", line 255, in _parse_object
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate value, obj_class())
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate File "/usr/lib/python2.7/dist-packages/designate/objects/adapters/yaml/base.py", line 32, in parse
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate cls.ADAPTER_FORMAT, values, output_object, *args, **kwargs)
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate File "/usr/lib/python2.7/dist-packages/designate/objects/adapters/base.py", line 185, in parse
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate raise exceptions.InvalidObject(error_message)
2018-03-07 00:59:01 DEBUG identity-service-relation-changed 2018-03-07 00:59:01.948 154825 ERROR designate InvalidObject: Provided object is not valid. Got a TypeError with message 'NoneType' object is not iterable

[Ashley Lai (alai)]

https://solutions.qa.canonical.com/#/qa/testRun/9f2c32c8-2b8d-45c6-83c5-5f2d12fc43cf

[Jason Hobbs (jason-hobbs)]

this looks suspicious:

http://paste.ubuntu.com/p/zybkfz4BHx/

shouldn't that be release = 'queens' ?

[Jason Hobbs (jason-hobbs)]

by the looks of it, it's running the Queens specific code on any openstack release >= ocata. I think this will break any designate deploy on ocata or pike.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550643
Committed: https://git.openstack.org/cgit/openstack/charm-designate/commit/?id=f77343de08e5ea1d050ba5d660c73d001461fa12
Submitter: Zuul
Branch: master

commit f77343de08e5ea1d050ba5d660c73d001461fa12
Author: Liam Young <email address hidden>
Date: Wed Mar 7 23:04:08 2018 +0000

    Ensure the correct charm class is chosen

    Fix charm class selection and ensure that pools.yaml dopes not
    render with empty values for NS records

    Change-Id: Ib642f49bc031ad8bacd4863426e87f4559e39f5f
    Closes-Bug: #1754148

[Ashley Lai (alai)]

The provided fix worked for us. We got a passing run in Pike.