Built charm contains configuration options that are unexpected and/or invalid for the charm

[Frode Nordahl]

The reactive charms consume layers for re-use of common reactive helpers and configuration options.

However some of the configuration options added to the layers are not valid for all charms.

Some layers have ``deletes`` lists under the ``config`` section to save the charms from having to do this, but when the upper charm layer also adds a ``deletes`` list it appears these are not merged but the charm one replaces the above layers deletes lists. This may provide unexpected results for the built charm.

We need to revisit each individual charm and make sure that the configuration options that show up in the built charm actually make sense and have supporting code in the charm.

Any configuration options that should not be there must be removed by adding them to the ``deletes`` list under the ``config`` section in ``layer.yaml`` of the upper charm layer.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/728651

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/728652

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/728653

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/728654

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/728656

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/728657

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/728658

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/728660

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/728770

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728651
Committed: https://git.openstack.org/cgit/x/charm-ovn-central/commit/?id=8b733fed727048379caa34c1ca094d989be6d174
Submitter: Zuul
Branch: master

commit 8b733fed727048379caa34c1ca094d989be6d174
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 22:11:36 2020 +0200

    Remove inherited configuration options invalid for charm

    The shared OVN code that previously was distributed using the
    OVN layer is now in c-h. The ovn-central charm does not have
    common code with the chassis charms so it is safe to switch to
    consuming the openstack layer directly.

    Change-Id: I87706f0ba005d18688c4b87bc5fc1b7115fcf7d5
    Closes-Bug: #1879088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728652
Committed: https://git.openstack.org/cgit/x/charm-ovn-dedicated-chassis/commit/?id=15074aa4f043907f7c27376928fd072520bfa7bf
Submitter: Zuul
Branch: master

commit 15074aa4f043907f7c27376928fd072520bfa7bf
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 22:32:51 2020 +0200

    Remove inherited configuration options invalid for charm

    The charm removes some configuration options only valid for the
    subordinate chassis charm. A side effect of this is that the
    deletes section in the OVN layer is replaced by ours, and we then
    need to delete configuration options inherited from upstream
    layers ourself.

    Add missing icon.

    Change-Id: I3fd02dee2968ee773ef2b31c18f7c674b12adf43
    Closes-Bug: #1879088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728661
Committed: https://git.openstack.org/cgit/openstack/charm-manila-generic/commit/?id=9bf02c7ff897a2f96192c56843e6356846fbddaf
Submitter: Zuul
Branch: master

commit 9bf02c7ff897a2f96192c56843e6356846fbddaf
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 23:34:29 2020 +0200

    Remove inherited configuration options invalid for charm

    Change-Id: Ia3b01d732d1813bb94a27086e10539c0b5499a49
    Closes-Bug: #1879088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728770
Committed: https://git.openstack.org/cgit/openstack/charm-octavia-dashboard/commit/?id=0a41348eabd990753da0de1b905f41f0727209e6
Submitter: Zuul
Branch: master

commit 0a41348eabd990753da0de1b905f41f0727209e6
Author: Frode Nordahl <email address hidden>
Date: Mon May 18 09:54:39 2020 +0200

    Remove inherited configuration options invalid for charm

    Change-Id: Ifd096de5ad0c58d3798567608ea99f258d98e1bf
    Closes-Bug: #1879088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728659
Committed: https://git.openstack.org/cgit/openstack/charm-cinder-purestorage/commit/?id=761a970780d03f203259a6964fad7f0a6fe0e1bb
Submitter: Zuul
Branch: master

commit 761a970780d03f203259a6964fad7f0a6fe0e1bb
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 23:24:02 2020 +0200

    Remove inherited configuration options invalid for charm

    Change-Id: I7e0023acc1277a0edbdda09b6069a7c8e62c2b0a
    Closes-Bug: #1879088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728656
Committed: https://git.openstack.org/cgit/openstack/charm-barbican-softhsm/commit/?id=161aaef2f27eff288bdb3de8afc2bfe693d804cc
Submitter: Zuul
Branch: master

commit 161aaef2f27eff288bdb3de8afc2bfe693d804cc
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 23:08:59 2020 +0200

    Remove inherited configuration options invalid for charm

    Change-Id: I33a9602793c2a19d8d21e4524999c5c2dd51e85f
    Closes-Bug: #1879088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728654
Committed: https://git.openstack.org/cgit/openstack/charm-octavia-dashboard/commit/?id=df4cc4403327375f4f5cbc05ba18b3b21cad5150
Submitter: Zuul
Branch: master

commit df4cc4403327375f4f5cbc05ba18b3b21cad5150
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 22:58:42 2020 +0200

    Remove inherited configuration options invalid for charm

    Change-Id: Icd93c7289e2da3440b991b9d2cd389f4892c87f4
    Closes-Bug: #1879088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728658
Committed: https://git.openstack.org/cgit/openstack/charm-cinder-backup-swift-proxy/commit/?id=bdbaa53af8303abbc7ad2726533464b2eb0ab371
Submitter: Zuul
Branch: master

commit bdbaa53af8303abbc7ad2726533464b2eb0ab371
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 23:18:44 2020 +0200

    Remove inherited configuration options invalid for charm

    Change-Id: I7fbc6b07d1e6fe93b67cafcba0ad0055d161dcd2
    Closes-Bug: #1879088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728660
Committed: https://git.openstack.org/cgit/openstack/charm-keystone-ldap/commit/?id=3f72380e220d44b3886b29f14273bb64d7679ee2
Submitter: Zuul
Branch: master

commit 3f72380e220d44b3886b29f14273bb64d7679ee2
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 23:29:14 2020 +0200

    Remove inherited configuration options invalid for charm

    Change-Id: I01cd3a3f53b09edb46398c7652ba19a6b1df4623
    Closes-Bug: #1879088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728657
Committed: https://git.openstack.org/cgit/openstack/charm-barbican-vault/commit/?id=c83001ca8aba7ad425dd349def85e5e03e371164
Submitter: Zuul
Branch: master

commit c83001ca8aba7ad425dd349def85e5e03e371164
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 23:15:10 2020 +0200

    Remove inherited configuration options invalid for charm

    Change-Id: I6089eae63aca83fccb7c2ecb39b21455464835b3
    Closes-Bug: #1879088

[Nobuto Murata (nobuto)]

Designate-bind doesn't offer TLS related service either.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/728653
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-rbd-mirror/commit/?id=3f11c3850acdd624af37046ec2a2556dc51829db
Submitter: Zuul
Branch: master

commit 3f11c3850acdd624af37046ec2a2556dc51829db
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 22:40:48 2020 +0200

    Remove inherited configuration options invalid for charm

    A side effect of adding a config keyword in layer.yaml is that
    any deletes done by upstream layers are overridden, so we
    add the complete set of configuration options inherited that
    should not be included in the built charm.

    Change-Id: I91e4e52600e7d632bbcf62402e57ebf69b6a3ea5
    Closes-Bug: #1879088