Broken replication_device config line when sync replication enabled

[Walid Moghrabi]

Hi,

I configured cinder replication with cinder-purestorage in sync "Active Cluster" mode.
My settings are good (everything works as expected) but I had to manually edit the cinder.conf generated by the charm because there is a bug when configuiring replication.

Taking a look at the generated cinder.conf, I saw this :

==================================================================
[cinder-purestorage-array]
san_ip = <primary_array_mgmt_ip>
pure_api_token = <primary_array_token>

use_multipath_for_image_xfer = True
image_volume_cache_enabled = True
pure_eradicate_on_delete = False
pure_automatic_max_oversubscription_ratio = True
volume_driver = cinder.volume.drivers.pure.PureISCSIDriver
volume_backend_name = pure-array-iscsi
allowed_direct_url_schemes = cinder
image_volume_cache_max_size_gb = 0
image_volume_cache_max_count = 0
replication_device = backend_id:X50VILP1,san_ip:<secondary_array_mgmt_ip>,api_token:<secondary_array_token>
,type:sync,uniform:true <======= see here, there is a newline that was added in the "replication_device" config
pure_iscsi_cidr = 10.23.0.0/18
==================================================================

In the cinder-volume logs, I can see this line :
2023-02-21 16:44:27.924 243094 INFO cinder.volume.drivers.pure [req-12796653-16a0-47f6-b47d-45d661456e27 - - - - -] Added secondary array: backend_id='X50VILP1', name='X50VILP1', id='b6c0989e-cb27-4ee8-8279-c6dfb4fd19f6', type='async', uniform='False'

See the last options : "type='async', uniform='False'" which doesn't match what has been configured in the charm.

I fixed the line in cinder.conf and restart the cinder-volume service :

=========================================================================================================
2023-02-21 16:54:51.161 453876 INFO cinder.volume.drivers.pure [req-af500264-e046-4755-a480-12c7c4a9704b - - - - -] Added secondary array: backend_id='X50VILP1', name='X50VILP1', id='b6c0989e-cb27-4ee8-8279-c6dfb4fd19f6', type='sync', uniform='True' <============= now that's good

Regarding charm version, I'm using the "yoga/stable" branch.

App Version Status Scale Charm Channel Rev
cinder 20.1.0 active 3 cinder yoga/stable 603
cinder-mysql-router 8.0.32 active 6 mysql-router 8.0/stable 35
cinder-purestorage-array 1.18.1 active 3 cinder-purestorage yoga/stable 115
cinder-volume 20.1.0 active 3 cinder yoga/stable 603