charm does not block when missing required config (san-ip)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Cinder Pure Storage Charm |
Invalid
|
Undecided
|
Narinder Gupta | ||
OpenStack Cinder Pure Storage Charm |
Fix Committed
|
Undecided
|
Unassigned |
Bug Description
The charm does not go into a blocked state when it is missing a required config option (san-ip). It goes into a hook error, but it should guard against this and go into a blocked state instead.
2019-07-10 20:34:40 DEBUG install Traceback (most recent call last):
2019-07-10 20:34:40 DEBUG install File "/var/lib/
2019-07-10 20:34:40 DEBUG install main()
2019-07-10 20:34:40 DEBUG install File "/var/lib/
2019-07-10 20:34:40 DEBUG install bus.discover()
2019-07-10 20:34:40 DEBUG install File "/var/lib/
2019-07-10 20:34:40 DEBUG install _register_
2019-07-10 20:34:40 DEBUG install File "/var/lib/
2019-07-10 20:34:40 DEBUG install _load_module(root, filepath)
2019-07-10 20:34:40 DEBUG install File "/var/lib/
2019-07-10 20:34:40 DEBUG install return importlib.
2019-07-10 20:34:40 DEBUG install File "/var/lib/
2019-07-10 20:34:40 DEBUG install return _bootstrap.
2019-07-10 20:34:40 DEBUG install File "<frozen importlib.
2019-07-10 20:34:40 DEBUG install File "<frozen importlib.
2019-07-10 20:34:40 DEBUG install File "<frozen importlib.
2019-07-10 20:34:40 DEBUG install File "<frozen importlib.
2019-07-10 20:34:40 DEBUG install File "<frozen importlib.
2019-07-10 20:34:40 DEBUG install File "<frozen importlib.
2019-07-10 20:34:40 DEBUG install File "/var/lib/
2019-07-10 20:34:40 DEBUG install import charm.openstack
2019-07-10 20:34:40 DEBUG install File "lib/charm/
2019-07-10 20:34:40 DEBUG install charms_
2019-07-10 20:34:40 DEBUG install File "lib/charm/
2019-07-10 20:34:40 DEBUG install ('san_ip', self.config.
2019-07-10 20:34:40 DEBUG install NameError: name 'self' is not defined
2019-07-10 20:34:40 ERROR juju.worker.
Changed in charm-cinder-pure-storage: | |
assignee: | nobody → Narinder Gupta (narindergupta) |
status: | New → In Progress |
Changed in charm-cinder-pure-storage: | |
status: | In Progress → Fix Released |
status: | Fix Released → New |
status: | New → Invalid |
This seems fixed, see lp:1959902