ceph-mon charm incorrectly embed ntp package installation

[Patrizio Bassi]

as in https://github.com/openstack/charm-ceph-mon/blob/733bad44f2689b2bdf61847d21a0e0109c2a4438/lib/ceph/__init__.py#L76

ntp is a mandatory dependency in ceph-mon charm.
This is not needed, expecially when deployed in a lxc container, but even on bare metal it may mess up things set up by ntp charm relation. (i'm thinking about an openstack deployment)

Can you please evaluate if removal is safe?

[Ryan Beisner (1chb1n)]

Copied the following comment from dup bug 1690514:

as in https://github.com/openstack/charm-ceph-radosgw/blob/fd401d5b95a0cda5763a44946df80c6b1951561d/hooks/hooks.py#L86

ntp is a mandatory dependency in ceph-radosgw charm.
This is not needed, expecially when deployed in a lxc container, but even on bare metal it may mess up things set up by ntp charm relation. (i'm thinking about an openstack deployment)

Can you please evaluate if removal is safe?

[Patrizio Bassi (patrizio-bassi)]

Why duplicate? It Is the same issue but in different charm...

[James Page (james-page)]

@Patrizio

We can track resolution of the same problem across multiple charms this way - each charm is a task on the bug.

[David Ames (thedac)]

Going through CI now
https://review.openstack.org/#/q/topic:bug/169051

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465142
Committed: https://git.openstack.org/cgit/openstack/charm-ceph/commit/?id=04b8f8492737b429a1465e609c72174171d433ac
Submitter: Jenkins
Branch: master

commit 04b8f8492737b429a1465e609c72174171d433ac
Author: David Ames <email address hidden>
Date: Tue May 16 11:22:55 2017 -0700

    Do not install NTP when installed in a container

    Use determine_packages() to avoid installing NTP when in a container.
    Sync charms.ceph to get ceph.determine_packages().

    Change-Id: Ia00af86964d8f77e615367cbcde35a4d7d10774c
    Partial-Bug: #1690513

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465137
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-radosgw/commit/?id=858ce946bb001ffc8068af584df21f7e2f6b148f
Submitter: Jenkins
Branch: master

commit 858ce946bb001ffc8068af584df21f7e2f6b148f
Author: David Ames <email address hidden>
Date: Tue May 16 11:11:53 2017 -0700

    Do not install NTP when installed in a container

    Check if the charm is installed inside a container and do not install
    NTP if that is the case.

    Partial-Bug: #1690513
    Change-Id: Ib290733a175197dee1261043a1e8ff2edc0b53e5

[James Page (james-page)]

Marking ceph task Fix Released as this was resolved in charms.ceph, and ceph got a sync prior to the 17.08 release.