ceph-radosgw/config.yaml fails lint

[Tilman Baumann]

$ yamllint config.yaml
config.yaml
  1:1 warning missing document start "---" (document-start)
  63:14 warning truthy value is not quoted (truthy)
  85:14 warning truthy value is not quoted (truthy)
  145:14 warning truthy value is not quoted (truthy)
  150:14 warning truthy value is not quoted (truthy)
  279:3 error duplication of key "haproxy-server-timeout" in mapping (key-duplicates)
  285:3 error duplication of key "haproxy-client-timeout" in mapping (key-duplicates)
  291:3 error duplication of key "haproxy-queue-timeout" in mapping (key-duplicates)
  297:3 error duplication of key "haproxy-connect-timeout" in mapping (key-duplicates)
  323:1 error too many blank lines (1 > 0) (empty-lines)

Somehow the haproxy-* keys got duplicated.

I have a fix for it which I will try to feed through gerrit...

[Tilman Baumann (tilmanbaumann)]

Review https://bugs.launchpad.net/charms/+source/ceph-radosgw/+bug/1747002

[Corey Bryant (corey.bryant)]

Note, the config duplicates are exact duplicates, so no change in behavior expected if they're removed.

[Corey Bryant (corey.bryant)]

Seems like perhaps we should start running yamllint as part of tox. We could propose a change for that and see what others think.

[Tilman Baumann (tilmanbaumann)]

I think that would be a good test.
YAML files are easily broken by accident since they are sensitive to hidden whitespace mismatches. (python legacy)
Happens easily when you edit a file.

[Corey Bryant (corey.bryant)]

Review: https://review.openstack.org/#/c/540396