Remove default debug settings from ceph charms

Bug #2056170 reported by Ponnuvel Palaniyappan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceph Monitor Charm
Triaged
Wishlist
Unassigned
Ceph OSD Charm
Triaged
Wishlist
Unassigned
Ceph RADOS Gateway Charm
Triaged
Wishlist
Unassigned
OpenStack Ceph-FS Charm
Triaged
Wishlist
Unassigned

Bug Description

ceph-{charms} set various default debug-{subsystem} values.

This is all setting the same default value as what they'd have been otherwise set by Ceph.

But this makes changing them via Ceph config database impossible
as the local /etc/ceph.conf takes priority and ignored config db values.

I don't see any advantage to setting these defaults in the charms.
While we can still keep the option configurable in the charms,
I think we should just get rid of the setting any default values.

description: updated
Revision history for this message
Peter Sabaini (peter-sabaini) wrote :

@Ponnuvel,
we're setting the debug mon and debug osd settings in ceph.conf, these should be configurable via the loglevel option though.

From the ceph.conf template:

debug mon = {{ loglevel }}/5
debug osd = {{ loglevel }}/5

Does this not work for you?

Changed in charm-ceph-fs:
status: New → Incomplete
Changed in charm-ceph-radosgw:
status: New → Incomplete
Changed in charm-ceph-osd:
status: New → Incomplete
Changed in charm-ceph-mon:
status: New → Incomplete
Revision history for this message
Peter Sabaini (peter-sabaini) wrote :

Or is the ask not to set anything in ceph.conf *unless* an explicit value has been configured via loglevel?

Revision history for this message
Ponnuvel Palaniyappan (pponnuvel) wrote :

@Peter

> Or is the ask not to set anything in ceph.conf *unless* an explicit value has been configured via loglevel?

Yes.

To be clear, this isn't a bug. I am not suggesting that we remove the loglevel from the charms - just suggesting that *not* setting any defaults makes it better if one wants to use Ceph's config database (which is better for managing configuration changes and is what upstream recommends rather the ceph.conf).

Somewhat related: https://bugs.launchpad.net/charm-ceph-mon/+bug/1891096

i.e. simply leave the "defaults:" empty (like we do for several other options) and if someone does set via juju, so be it.

Revision history for this message
Peter Sabaini (peter-sabaini) wrote :

This seems reasonable, thanks Pon

Changed in charm-ceph-mon:
status: Incomplete → Triaged
Changed in charm-ceph-osd:
status: Incomplete → Triaged
Changed in charm-ceph-radosgw:
status: Incomplete → Triaged
Changed in charm-ceph-fs:
status: Incomplete → Triaged
Changed in charm-ceph-mon:
importance: Undecided → Wishlist
Changed in charm-ceph-osd:
importance: Undecided → Wishlist
Changed in charm-ceph-radosgw:
importance: Undecided → Wishlist
Changed in charm-ceph-fs:
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.