Running zap-disk action with devices separated by more then one space dies with an unhelpful error message

[Peter Sabaini]

Running zap-disk with:

juju run-action --wait ceph-osd/48 zap-disk devices='/dev/disk/by-dname/bcache-sdb /dev/disk/by-dname/bcache-sdc /dev/disk/by-dname/bcache-sdd' i-really-mean-it=True

This dies with:

2021-05-31 09:23:09 DEBUG zap-disk Traceback (most recent call last):
2021-05-31 09:23:09 DEBUG zap-disk File "/var/lib/juju/agents/unit-ceph-osd-48/charm/actions/zap-disk", line 94, in <module>
2021-05-31 09:23:09 DEBUG zap-disk zap()
2021-05-31 09:23:09 DEBUG zap-disk File "/var/lib/juju/agents/unit-ceph-osd-48/charm/actions/zap-disk", line 53, in zap
2021-05-31 09:23:09 DEBUG zap-disk devices = get_devices()
2021-05-31 09:23:09 DEBUG zap-disk File "/var/lib/juju/agents/unit-ceph-osd-48/charm/actions/zap-disk", line 41, in get_devices
2021-05-31 09:23:09 DEBUG zap-disk raise
2021-05-31 09:23:09 DEBUG zap-disk RuntimeError: No active exception to reraise

This is due to the action not handling the two consecutive whitespaces in the args

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-ceph-osd/+/793812

[Peter Sabaini (peter-sabaini)]

PS.: on master I can see the faulty exception raise was already fixed, so the error message is already a bit more helpful

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Chris MacNaughton <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-ceph-osd/+/793812
Reason: Closing this review as it has updates requested for over a year and no updates submitted.