osd-out & osd-in actions should take an osd-id argument

Bug #1910150 reported by Adam Dyess
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceph OSD Charm
Fix Released
Undecided
Robert Gildein

Bug Description

Could the charm accept an osd-id as an optional argument to run this action for a specific osd? It could be really handy to out a single osd as a part of drive maintenance.

Adam Dyess (addyess)
description: updated
Adam Dyess (addyess)
summary: - osd-out-in actions should take an osd-id argument
+ osd-out & osd-in actions should take an osd-id argument
Revision history for this message
James Troup (elmo) wrote :

Actually, I'd go further than that, either this action should require an --all flag, or it should be renamed. It's dangerous and counter-intuitive for a command called 'osd-out' to actually take out *all* the OSDs of a unit.

Changed in charm-ceph-osd:
status: New → In Progress
assignee: nobody → Robert Gildein (rgildein)
Revision history for this message
Aurelien Lourot (aurelien-lourot) wrote :

Maybe use the same kind of arguments as the new `start` and `stop` actions?
https://github.com/openstack/charm-ceph-osd/commit/e22f60254455b3b98f52909fd25d4a4a8de09bb4

Revision history for this message
Robert Gildein (rgildein) wrote :

Yes, I agree to use the same argument used in another action. I'm working on it, I still have to test it properly.

Revision history for this message
Aurelien Lourot (aurelien-lourot) wrote :
Changed in charm-ceph-osd:
status: In Progress → Fix Committed
milestone: none → 21.01
David Ames (thedac)
Changed in charm-ceph-osd:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.