action zap-disk does not allow zapping of vault-encrypted bluestore bcache paths

[Drew Freiberger]

When running ceph-osd zap disk action (after stopping ceph-osd@$ID.service and purging it from ceph crush map), the check whether the device is in use marks the disk as un-zappable because it's mounted (or in use by bluestore or is part of a luks crypt).

If I first remove the pv forcibly and close the crypt, I can then successfully zap-disk with the action.

for i in $(ceph-volume-lvm-list | grep 'block device' |awk '{print \$3}'); do ceph-volume lvm zap $i; done"

pvs|awk '/ceph/ {print \$1}'|xargs -I@ pvremove @ --force --force -y

juju run -u $unt "grep mapper/crypt /home/ubuntu/ceph-volume-lvm-list.txt |cut -d- -f2-|sudo xargs -I@ cryptsetup luksClose /dev/mapper/crypt-@"

This is on charm ceph-osd-294 running on bionic with source:distro (queens)

I believe that the action used to work before vault encrypted disks and that the function to check if a device is mounted was expanded to also check if it was part of a bluestore or luks process. This check needs a bit more nuance for the specific zap-disk action where we expect to override and tear down anything on the disk when the action is called.