Only initialize disks once confirmed that all block devices exist

Bug #1871276 reported by Wouter van Bommel
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceph OSD Charm
Expired
Medium
Unassigned

Bug Description

If the ceph-osd config does not match the actual layout of an machine, the charm should not execute the lvm related part of the disk setup.

In this occurrence the bluestore-wal and bluestore-db where configured to the 'wrong' partition on an nvme.
While this was the case the charm still configured all the osd's with encryption, pv's, vg's, and lv's.
Once the error was found and corrected, the charm got blocked, complaining that it could not find any pristine disks, which is to be expected as those where already configured by the charm itself, but the osd configuration could not finish as the bluestore related setting where wrong.

That these settings are wrong does happen from time to time in practice with expansion of clouds when the new machine's cannot be configured exactly the same and during the inital phase maas was not setup to use labels for the bluestore-wal and bluestore-db entries (something that is common).

Revision history for this message
James Page (james-page) wrote :

I think it would be reasonable for the charm to go into a block state if the wal and db configuration options are populated, but the devices don't actually exist on the unit being used.

This would avoid just the block device part being created and used for the OSD.

As these options are whitelists its possible you won't get an exact device match for every device, but we could at least do a >= 1 of type check to validate this.

Revision history for this message
James Page (james-page) wrote :

As this is a fairly significant behavioural change I don't think this is suitable to fix under a field-high subscription.

Please consider switching to field-medium and requesting inclusion in the stable maintenance bug focus for this or next development cycle.

Changed in charm-ceph-osd:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
James Page (james-page) wrote :

Marking Incomplete for now - as detailed in #2 this is not really suitable for a field-high - please consider re-classifying as a field-medium.

Changed in charm-ceph-osd:
status: Triaged → Incomplete
Revision history for this message
Billy Olsen (billy-olsen) wrote :

As a behavioral change, this is more in line with a feature request which is not eligible for field SLA. I recognize that this would be beneficial, however we should plan it into cycle as appropriate. I am therefore removing field sla subscription

Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for OpenStack ceph-osd charm because there has been no activity for 60 days.]

Changed in charm-ceph-osd:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.