list-disk action wrongly report journal_disk as non-pristine disk

[dongdong tao]

If the osd-journal config use the journal device's symbol link as the value.
This will result the juju list-disk action wrongly report a journal device as non pristine.

list-disk action tried to exclude the journal device when it's trying to detect all the non-pristine devices.
we can see below code from :
----
 osd_journal = utils.get_journal_devices()
 for dev in list(set(ceph.utils.unmounted_disks()) - set(osd_journal)):
        if (not ceph.utils.is_active_bluestore_device(dev) and
                not ceph.utils.is_pristine_disk(dev)):
            non_pristine.append(dev)
----

The problem here is that ceph.utils.unmounted_disks() always return the real path while osd_journal might be just symbol link.

[dongdong tao (taodd)]

I'll submit a patch soon

[dongdong tao (taodd)]

https://review.opendev.org/#/c/688372/

[dongdong tao (taodd)]

I'll fix the fail soon

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/688372
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=8ca701eb878abbe31034e871fc1508e9bed47093
Submitter: Zuul
Branch: master

commit 8ca701eb878abbe31034e871fc1508e9bed47093
Author: taodd <email address hidden>
Date: Mon Oct 14 18:18:10 2019 +0800

    Fix list-disk action wrongly report osd journal as the non-pristine device

    Change-Id: Ib117fc5797447ade75d50a7ff7dae5de473fe7b9
    Closes-Bug: #1847988