list-disk action breaks with udev path based configuration

[Gábor Mészáros]

If I have the following setup:
$ juju config ceph-osd osd-devices
/dev/disk/ceph/osd-sdc /dev/disk/ceph/osd-sdd
$ juju config ceph-osd-std osd-journal
/dev/disk/ceph/journal-sda /dev/disk/ceph/journal-sdb

created by a custom udev rule, the charm will find the journal devices non-pristine, as they have no partition mounted on those drives and they are listed with their udev names in the juju config.

Fix is simple, check the realpath of the journal drives during the list-disk action.
Something like
from os.path import realpath
    for dev in list(set(ceph.utils.unmounted_disks()) - set(realpath(d) for d in set(osd_journal))):
instead of
    for dev in list(set(ceph.utils.unmounted_disks()) - set(osd_journal)):

https://github.com/openstack/charm-ceph-osd/blob/master/actions/list_disks.py#L44

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/663587

[OpenStack Infra (hudson-openstack)]

Change abandoned by Gábor Mészáros (<email address hidden>) on branch: master
Review: https://review.opendev.org/663587

[Luciano Lo Giudice (lmlogiudice)]

Listing journal devices now uses the realpath instead of the raw path, so the fix proposed has been applied (although not tested). I unfortunately don't have an environment with a similar setup to try it out. Could you say if the issue is still present, Gábor ?

[Launchpad Janitor (janitor)]

[Expired for Ceph OSD Charm because there has been no activity for 60 days.]