add-disk action with ceph jewel breaks with default bluestore setting

[Edward Hope-Morley]

Deployed 3 osd cluster all good. Then did add-disk action for 3 extra disks and got the following for all 3 new disks:

2019-03-15 12:28:33.687278 7f0ad38e0b00 -1 unable to create object store
2019-03-15 12:29:50.635098 7f4aac13eb00 0 set uid:gid to 64045:64045 (ceph:ceph)
2019-03-15 12:29:50.635236 7f4aac13eb00 0 ceph version 10.2.11 (e4b061b47f07f583c92a050d9e84b1813a35671e), process ceph-osd, pid 14778
2019-03-15 12:29:50.635305 7f4aac13eb00 5 object store type is bluestore
2019-03-15 12:29:50.635340 7f4aac13eb00 -1 *** experimental feature 'bluestore' is not enabled ***
This feature is marked as experimental, which means it
 - is untested
 - is unsupported
 - may corrupt your data
 - may break your cluster is an unrecoverable fashion
To enable this feature, add this to your ceph.conf:
  enable experimental unrecoverable data corrupting features = bluestore

[Edward Hope-Morley (hopem)]

In other words, I deployed a Ceph cluster from the Ocata UCA (i.e. Jewel) with charm defaults left alone so bluestore=enabled. The deployment worked fine and I ended up with 3 Filestore OSDs as expected. I then did add-disk for 3 more OSD disks and it failed with ^^.

[Chris MacNaughton (chris.macnaughton)]

I'm not sure why gerrit isn't updating this but I'm working on this bug in this topic: https://review.openstack.org/#/q/status:open+topic:bug/1820271

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/643575
Committed: https://git.openstack.org/cgit/openstack/charms.ceph/commit/?id=98183011bba073d6665780083ca54413d82d8dcf
Submitter: Zuul
Branch: master

commit 98183011bba073d6665780083ca54413d82d8dcf
Author: Chris MacNaughton <email address hidden>
Date: Fri Mar 15 14:02:26 2019 +0100

    Update bluestore checks to match what we use in ceph-osd hooks

    Change-Id: I2ea119f5a1b2a36ccd36df4db094f208a1db100e
    Closes-Bug: #1820271

[Alex Kavanagh (ajkavanagh)]

This bug is almost certainly fixed as the relevant charms.ceph code is merged (and more up-to-date) into the ceph-osd charm.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-osd/+/643577
Committed: https://opendev.org/openstack/charm-ceph-osd/commit/ea56c2c19748026193cbb32faee17e760333ef40
Submitter: "Zuul (22348)"
Branch: master

commit ea56c2c19748026193cbb32faee17e760333ef40
Author: Chris MacNaughton <email address hidden>
Date: Fri Mar 15 14:06:02 2019 +0100

    Ensure add-disk and hooks handle disks the same way

    Depends-On: I2ea119f5a1b2a36ccd36df4db094f208a1db100e
    Depends-On: Ie19e5318ea35c38e5d02963260b85fec0f233df6
    Change-Id: Idebe45504233fb5559a3e9ddd9b2d6534cba7bb2
    Closes-Bug: #1820271