ceph-osd fails upgrade-charm because of missing smartmontools in emit_cephconf

[Chris MacNaughton]

2019-03-12 13:53:47 DEBUG worker.uniter.jujuc server.go:182 running hook tool "storage-list"
2019-03-12 13:53:47 DEBUG upgrade-charm Traceback (most recent call last):
2019-03-12 13:53:47 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-ceph-osd-2/charm/hooks/upgrade-charm.real", line 826, in <module>
2019-03-12 13:53:47 DEBUG upgrade-charm hooks.execute(sys.argv)
2019-03-12 13:53:47 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-ceph-osd-2/charm/hooks/charmhelpers/core/hookenv.py", line 909, in execute
2019-03-12 13:53:47 DEBUG upgrade-charm self._hooks[hook_name]()
2019-03-12 13:53:47 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-ceph-osd-2/charm/hooks/charmhelpers/contrib/hardening/harden.py", line 93, in _harden_inner2
2019-03-12 13:53:47 DEBUG upgrade-charm return f(*args, **kwargs)
2019-03-12 13:53:47 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-ceph-osd-2/charm/hooks/upgrade-charm.real", line 634, in upgrade_charm
2019-03-12 13:53:47 DEBUG upgrade-charm emit_cephconf()
2019-03-12 13:53:47 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-ceph-osd-2/charm/hooks/upgrade-charm.real", line 433, in emit_cephconf
2019-03-12 13:53:47 DEBUG upgrade-charm context = get_ceph_context(upgrading)
2019-03-12 13:53:47 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-ceph-osd-2/charm/hooks/upgrade-charm.real", line 395, in get_ceph_context
2019-03-12 13:53:47 DEBUG upgrade-charm cephcontext['bdev_discard'] = should_enable_discard(get_devices())
2019-03-12 13:53:47 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-ceph-osd-2/charm/hooks/utils.py", line 216, in should_enable_discard
2019-03-12 13:53:47 DEBUG upgrade-charm is_sata30orless(device)):
2019-03-12 13:53:47 DEBUG upgrade-charm File "/var/lib/juju/agents/unit-ceph-osd-2/charm/hooks/utils.py", line 224, in is_sata30orless
2019-03-12 13:53:47 DEBUG upgrade-charm result = subprocess.check_output(["/usr/sbin/smartctl", "-i", device])
2019-03-12 13:53:47 DEBUG upgrade-charm File "/usr/lib/python3.6/subprocess.py", line 336, in check_output
2019-03-12 13:53:47 DEBUG upgrade-charm **kwargs).stdout
2019-03-12 13:53:47 DEBUG upgrade-charm File "/usr/lib/python3.6/subprocess.py", line 403, in run
2019-03-12 13:53:47 DEBUG upgrade-charm with Popen(*popenargs, **kwargs) as process:
2019-03-12 13:53:47 DEBUG upgrade-charm File "/usr/lib/python3.6/subprocess.py", line 709, in __init__
2019-03-12 13:53:47 DEBUG upgrade-charm restore_signals, start_new_session)
2019-03-12 13:53:47 DEBUG upgrade-charm File "/usr/lib/python3.6/subprocess.py", line 1344, in _execute_child
2019-03-12 13:53:47 DEBUG upgrade-charm raise child_exception_type(errno_num, err_msg, err_filename)
2019-03-12 13:53:47 DEBUG upgrade-charm FileNotFoundError: [Errno 2] No such file or directory: '/usr/sbin/smartctl': '/usr/sbin/smartctl'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/642756

[Chris MacNaughton (chris.macnaughton)]

Pending that fix, this can be resolved with

`juju run --application=ceph-osd "sudo apt-get install -yq smartmontools"`

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/642756
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=4e13ede1da0e22ade38e1c7123f59c42283ad42c
Submitter: Zuul
Branch: master

commit 4e13ede1da0e22ade38e1c7123f59c42283ad42c
Author: Chris MacNaughton <email address hidden>
Date: Tue Mar 12 14:55:53 2019 +0100

    Handle package installs before anything else

    Handling other functions of the charm upgrade before possible
    new packages leads to breakages when dependencies are unmet

    Change-Id: I0e4857d0d03c2d076290a4cc6a08dc1e6d5e1610
    Closes-Bug: #1819669